a2ui-project / a2ui-project/a2ui
Align removed/deleted verb in UiAgent
- Ngôn ngữ chính
- TypeScript
- Star
- 16.4k
- Fork
- 1.3k
- Merge trung bình
- 2 ngày 13 giờ
- Pull request đã merge (30 ngày)
- 134
Mô tả
_↴ Ported from [flutter/genui#418](https://github.com/flutter/genui/issues/418) — originally opened by [redbrogdon](https://github.com/redbrogdon) on 2025-10-21._
_Original labels: P3, front-line-handled, second-line-triaged_
---
(This is a nit, but since the API surface isn't fully stabilized yet... 😄 )
The `UiAgent` class uses the term "deleted" in its callback for removal of a surface, `onSurfaceDeleted`. That callback takes an instance of `SurfaceRemoved` as its lone argument:
https://github.com/flutter/genui/blob/main/packages/flutter_genui/lib/src/facade/ui_agent.dart#L160
Would it be possible to use the same verb for both?
---
### 1 comment(s) from the original issue
**[yjbanov](https://github.com/yjbanov)** commented on 2025-10-30:
Great point! We intend to take a look at this.
Hướng dẫn đóng góp
Hướng nghiên cứu
The issue is about aligning terminology in the UiAgent class. Look at the file packages/flutter_genui/lib/src/facade/ui_agent.dart, specifically the onSurfaceDeleted callback and the SurfaceRemoved argument type. Determine whether to rename the callback to onSurfaceRemoved or the argument type to SurfaceDeleted, ensuring consistency. Check for any other references to these names in the codebase to update them accordingly.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- flutter, typescript
- Lĩnh vực
- api, frontend
- Loại issue
- Tái cấu trúc
- Độ khó
- 1/5
- Thời gian dự kiến
- Dưới một giờ
- Mức độ hoạt động
- Ít trao đổi
- Độ rõ ràng
- Đặc tả rõ ràng
- Mức phù hợp với người mới
- 80/100