a2ui-project / a2ui-project/a2ui

Align removed/deleted verb in UiAgent

Offen
#1,831 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
component: genui P3 status: first-line-handled
Vorherrschende Sprache
TypeScript
Sterne
16.4k
Forks
1.3k
Ø Merge
2 T. 13 Std.
Gemergte PRs (30 T.)
134

Beschreibung

_↴ Ported from [flutter/genui#418](https://github.com/flutter/genui/issues/418) — originally opened by [redbrogdon](https://github.com/redbrogdon) on 2025-10-21._
_Original labels: P3, front-line-handled, second-line-triaged_

---

(This is a nit, but since the API surface isn't fully stabilized yet... 😄 )

The `UiAgent` class uses the term "deleted" in its callback for removal of a surface, `onSurfaceDeleted`. That callback takes an instance of `SurfaceRemoved` as its lone argument:

https://github.com/flutter/genui/blob/main/packages/flutter_genui/lib/src/facade/ui_agent.dart#L160

Would it be possible to use the same verb for both?

---

### 1 comment(s) from the original issue

**[yjbanov](https://github.com/yjbanov)** commented on 2025-10-30:

Great point! We intend to take a look at this.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.