a2aproject / a2aproject/a2a-java

fix: handle blank push notification config id consistently across transports

Aperta
#1,012 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Java
Stelle
490
Fork
172
Merge medio
1g 6h
PR unite (30g)
55

Descrizione

`GetTaskPushNotificationConfigParams` rejects a null `id` but permits an
empty string, and the two transports diverge on that input:

- `GrpcTransport` sends `.setId("")`.
- `RestTransport` treats it as absent and requests the trailing-slash
"default config" URL.

Identical caller code against the same `ClientTransport` method therefore
produces two different requests. This aligns both on
and adds coverage for the blank-id path, which was previously untested.

Also corrects the Javadoc on `GetTaskPushNotificationConfigParams`, which
described `id` as optional and documented `@throws` for `taskId or tenant`
when the constructor actually validates `taskId` and `id`.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.