a2aproject / a2aproject/a2a-java

fix: handle blank push notification config id consistently across transports

Ouverte
#1,012 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Java
Étoiles
490
Forks
172
Merge moyen
1 j 6 h
PR mergées (30 j)
55

Description

`GetTaskPushNotificationConfigParams` rejects a null `id` but permits an
empty string, and the two transports diverge on that input:

- `GrpcTransport` sends `.setId("")`.
- `RestTransport` treats it as absent and requests the trailing-slash
"default config" URL.

Identical caller code against the same `ClientTransport` method therefore
produces two different requests. This aligns both on
and adds coverage for the blank-id path, which was previously untested.

Also corrects the Javadoc on `GetTaskPushNotificationConfigParams`, which
described `id` as optional and documented `@throws` for `taskId or tenant`
when the constructor actually validates `taskId` and `id`.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.