a2aproject / a2aproject/a2a-java

fix: handle blank push notification config id consistently across transports

Open
#1,012 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
490
Forks
172
Avg merge
1d 6h
Merged PRs (30d)
55

Description

`GetTaskPushNotificationConfigParams` rejects a null `id` but permits an
empty string, and the two transports diverge on that input:

- `GrpcTransport` sends `.setId("")`.
- `RestTransport` treats it as absent and requests the trailing-slash
"default config" URL.

Identical caller code against the same `ClientTransport` method therefore
produces two different requests. This aligns both on
and adds coverage for the blank-id path, which was previously untested.

Also corrects the Javadoc on `GetTaskPushNotificationConfigParams`, which
described `id` as optional and documented `@throws` for `taskId or tenant`
when the constructor actually validates `taskId` and `id`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.