Prioritize used enums in selection dialog

Open
#6,420 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp

Research direction

No source file, test, or entry point is named. Start by locating the selection dialog implementation and determine how enum candidates are collected and ordered; done should make previously used enums easier to select while preserving a sensible ordering for unused enums.

Written by the indexing model from the issue text.

Description

Component: UI Effort: Low Impact: Low UI: Dialogs

What is the feature you'd like to have?
Please provide a clear and concise description of what you want.

With type libraries loaded, there can be a large number of enum types in a bndb. For example:

Image

This UI is great, no problem. I select _IRP_MJ which is the correct one for this call site. Now, I go to the next use in this function:

Image

This is reusing _IRP_MJ, but the UI does not prioritize recently used (or used at all) enums. I would like _IRP_MJ to be prioritized in some fashion to make it easier to select the second time.

I don't have any preferences as to how this is implemented.

Is your feature request related to a problem?
If applicable, please provide a clear and concise description of what the problem is.

Are any alternative solutions acceptable?
Please provide a clear and concise description of any alternative solutions or features you've considered.

Additional Information:
Please add any other context or screenshots that would help us understand your feature request here.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.