Plugin Callbacks should pass Function *

Open
#488 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
reverse-engineering

Research direction

Start in plugin.cpp at the RegisterForAddress callback around line 75 and the RegisterForRange callback around line 171. Trace the callback signatures and their uses, then update them so each receives the relevant Function alongside the address. Done means both plugin callbacks expose the Function context needed for overlapping disassembly and functions.

Written by the indexing model from the issue text.

Description

Component: API Effort: Medium Impact: Medium

For the plugin RegisterForAddress and RegisterForRange callbacks, they should pass the Function instance in addition to the address. Since Binja supports overlapping disassembly and overlapping functions, an address in isolation means nothing without its Function context.

These should pass the Function as well:
https://github.com/Vector35/binaryninja-api/blob/master/plugin.cpp#L75
https://github.com/Vector35/binaryninja-api/blob/master/plugin.cpp#L171

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.