System.ArgumentOutOfRangeException - SMSG_UPDATE_OBJECT (3.4.2.50063)
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- reverse-engineering, tooling
Research direction
Start with WowPacketParser/Misc/PacketReads.cs at FormatFloat, then trace the ReadSingle call from WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs in ReadMovementUpdateBlock. Reproduce the SMSG_UPDATE_OBJECT failure for client version 3.4.2.50063 and determine how the reported substring bounds should be handled; done means the packet parses without this exception.
Written by the indexing model from the issue text.
Description
System.ArgumentOutOfRangeException
Index and length must refer to a location within the string. (Parameter 'length')
at System.String.ThrowSubstringArgumentOutOfRange(Int32 startIndex, Int32 length)
at System.String.Substring(Int32 startIndex, Int32 length)
at WowPacketParser.Misc.Packet.FormatFloat(Single value) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParser\Misc\PacketReads.cs:line 742
at WowPacketParser.Misc.Packet.ReadSingle(String name, Object[] indexes) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParser\Misc\PacketReads.cs:line 362
at WowPacketParserModule.V2_5_1_38707.Parsers.UpdateHandler.ReadMovementUpdateBlock(Packet packet, WowGuid guid, WoWObject obj, Object index) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParserModule.V2_5_1_38707\Parsers\UpdateHandler.cs:line 436
at WowPacketParserModule.V2_5_1_38707.Parsers.UpdateHandler.ReadCreateObjectBlock(Packet packet, CreateObject createObject, WowGuid guid, UInt32 map, CreateObjectType createType, Object index) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParserModule.V2_5_1_38707\Parsers\UpdateHandler.cs:line 175
at WowPacketParserModule.V2_5_1_38707.Parsers.UpdateHandler.HandleUpdateObject(Packet packet) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParserModule.V2_5_1_38707\Parsers\UpdateHandler.cs:line 150
at WowPacketParser.Parsing.Handler.Parse(Packet packet, Boolean isMultiple) in C:\Users\benjy\Documents\GitHub\WowPacketParser\WowPacketParser\Parsing\Handler.cs:line 149
- Dominant language
- C#
- Stars
- 522
- Forks
- 387
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from TrinityCore/WowPacketParser
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
TrinityCore/WowPacketParser#990 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
TrinityCore/WowPacketParser#953 ·
-
3.4.3.55392 Open
Difficulty 4/5 3-5 days Newbie friendliness 20/100
TrinityCore/WowPacketParser#866 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
TrinityCore/WowPacketParser#836 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
TrinityCore/WowPacketParser#833 ·
All issues in TrinityCore/WowPacketParser
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·
-
area/docs-content Bug pulumi/docs
Difficulty 1/5 1-3 hours Newbie friendliness 94/100
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100