TrinityCore / TrinityCore/TrinityCoreCustomChanges
Solo LFG
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 83
- Forks
- 58
- PR merge metrics
- No merged PRs in 30d
Description
Description:
Solo LFG if you die you will be kicked out of the instance and the green icon will be gone on the minimap and you will have a Dungeon Finder cooldown.
Current behaviour:
If you leave or have to leave the instance in any way (because you died, for example), the dungeon browser ends. You cannot then continue or teleport. So you don't get a reward anymore, even if you go back into the instance and complete the dungeon.
Expected behaviour:
Solo LFG If you leave or have to leave the instance in any way (because you died for example), the dungeon browser ends. You cannot then continue or teleport. So you don't get a reward anymore, even if you go back to the instance and complete the dungeon and you have a cooldown right away
if you leave the dungeon browser briefly or die then you will not be kicked out of the dungeon browser and will not get a cooldown.
Branch(es):
3.3.5 branch
TC rev. hash/commit:
TrinityCore rev. a8475e5d70c4+ 2022-02-01 17:09:28 +0100 (3.3.5 branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon)
TDB version:
TDB 335.22011
Operating system: CHANGEME OS





Windows 10
Description:
Solo LFG if you die you will be kicked out of the instance and the green icon will be gone on the minimap and you will have a Dungeon Finder cooldown.
Current behaviour:
If you leave or have to leave the instance in any way (because you died, for example), the dungeon browser ends. You cannot then continue or teleport. So you don't get a reward anymore, even if you go back into the instance and complete the dungeon.
Expected behaviour:
Solo LFG If you leave or have to leave the instance in any way (because you died for example), the dungeon browser ends. You cannot then continue or teleport. So you don't get a reward anymore, even if you go back to the instance and complete the dungeon and you have a cooldown right away
if you leave the dungeon browser briefly or die then you will not be kicked out of the dungeon browser and will not get a cooldown.
Branch(es):
3.3.5 branch
TC rev. hash/commit:
TrinityCore rev. a8475e5d70c4+ 2022-02-01 17:09:28 +0100 (3.3.5 branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon)
TDB version:
TDB 335.22011
Operating system: CHANGEME OS
Windows 10
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue on the 3.3.5 branch using the reported solo LFG flow, then trace the dungeon browser handling for leaving an instance and dying. Done means briefly leaving or dying does not end the browser, remove the minimap indicator, prevent teleport or rewards, or apply a cooldown when the dungeon is completed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100