SolidOS / SolidOS/solid-ui

`tryParent` in acl.js does not stop before trying to fetch https://

Abierto
#78 0 comentarios 0 reacciones 1 asignado Ver en GitHub

@megoth ya está trabajando en esto.

Desde el 5/8/2019.

Lenguaje dominante
TypeScript
Estrellas
153
Forks
46
Merge medio
1 d 8 h
PR fusionados (30 d)
7

Descripción

tryParent is a recursive function that takes a URL (e.g. https://foo.com/bar/baz) and tries to find an ACL for that resource by looking at its parent if none are found initially (e.g. https://foo.com/bar/ --> https://foo.com/).

There are a couple of problems with this:

  1. Right now there is a bug that makes it also check https://. We need to stop the recursive function before this happens and give the appropriate error. (There should always be a root ACL, but errors might occur still.)
  2. It will call tryParent if no triples for acl:default are found (https://github.com/solid/solid-ui/blob/master/src/acl.js#L359). This would mean that even though an ACL resource are found, the code will still look for another parent ACL resource, which I think goes against point 2 in https://github.com/solid/web-access-control-spec#acl-inheritance-algorithm.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.