`tryParent` in acl.js does not stop before trying to fetch https://
Offen
@megoth arbeitet bereits daran.
Seit 05.8.2019.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 153
- Forks
- 46
- Ø Merge
- 1 T. 8 Std.
- Gemergte PRs (30 T.)
- 7
Beschreibung
tryParent is a recursive function that takes a URL (e.g. https://foo.com/bar/baz) and tries to find an ACL for that resource by looking at its parent if none are found initially (e.g. https://foo.com/bar/ --> https://foo.com/).
There are a couple of problems with this:
- Right now there is a bug that makes it also check https://. We need to stop the recursive function before this happens and give the appropriate error. (There should always be a root ACL, but errors might occur still.)
- It will call tryParent if no triples for
acl:defaultare found (https://github.com/solid/solid-ui/blob/master/src/acl.js#L359). This would mean that even though an ACL resource are found, the code will still look for another parent ACL resource, which I think goes against point 2 in https://github.com/solid/web-access-control-spec#acl-inheritance-algorithm.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Bewertung
Dieses Issue wurde noch nicht bewertet.