Fix or remove `num_traits` for performance
まだ誰も着手していません。
- 主要言語
- Rust
- スター
- 3.4k
- フォーク
- 126
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
We can't get rid of num_traits for silly rust reasons:
core::f32::powf is marked as #[rustc_allow_incoherent_impl], meaning it doesn't actually "exist" unless some other crate declares it. I'm not too familiar on the details, but it seems like when you have std it exists and if you only have core it's declared but doesn't exist and using it will fail with:
error[E0599]: no function or associated item named `powf` found for type `f32` in the current scope
--> crates/restir-shader/src/material/pbr/eval.rs:159:25
|
159 | f0 + (1.0 - f0) * f32::powf(f32::clamp(1.0 - cos_theta, 0.0, 1.0), 5.0)
| ^^^^ function or associated item not found in `f32`
|
= help: items from traits can only be used if the trait is in scope
see https://github.com/rust-lang/rust/issues/149347 on this sillyness
The workaround has usually been this use statement:
#[cfg(target_arch = "spirv")]
use spirv_std::num_traits::Float;
num_traits with std feature will call std functions and with libm feature / in #[no_std] environments call the appropriate libm function. For SPIR-V, our spirv-std configures the feature for you and we then intercept those libm calls and replace them with intrinsics.
While researching this, I've noticed this has been discussed in 2021 on the embark repo already, and their conclusion was:
I think this is a fully external issue, then - rust-gpu is working "as intended", faithfully compiling the code that it is given, which doesn't use an intrinsic. The way to fix this, then, would be to change upstream code to be less branchy (e.g. requesting that libm adds a powi intrinsic, and having num-traits call it).
I don't mind if we want to merge this anyway, so it's not a trap to end users @LegNeato.
But num-traits isn't a perfect solution either: Technically, it doesn't actually reimplement all f32 functions. For example, it excludes euclid, for which you need to use the Euclid trait, which takes args by reference instead of by value, so you'll get awful code like this (which initially sparked my investigation into this last summer):
#[cfg(feature = "std")]
let rem = |x: f32| x.rem_euclid(1.);
#[cfg(not(feature = "std"))]
let rem = |x: f32| x.rem_euclid(&1.);
Originally posted by @Firestar99 in https://github.com/Rust-GPU/rust-gpu/pull/518#discussion_r2717101573
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
crates/restir-shader/src/material/pbr/eval.rs と crates/spirv-std/Cargo.toml の spirv-std feature 設定から始めてください。リンクされている Rust と num-traits の議論を確認し、num_traits を修正すべきか削除すべきかを判断したうえで、関連する std および no_std/SPIR-V ビルドと影響を受ける浮動小数点呼び出しを検証してください。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- rust
- 領域
- computer-graphics
- issue の種類
- リファクタリング
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100