[Migrated] Rename spirv attribute
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 3.4k
- Forks
- 125
- PR merge metrics
- No merged PRs in 30d
Description
Issue automatically imported from old repo: https://github.com/EmbarkStudios/rust-gpu/issues/883
Originally creatd by oisyn on 2022-07-06T12:43:58Z 👍: 3
Although we only support SpirV as a target right now and implementing a DXIL backend would still be a thing of the distant future, it doesn't make much sense to have the attribute that annotates generic gpu stuff be called "spirv". Changing it into a more platform agnostic name early on in the project would prevent breaking a lot of GPU code later on.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by locating the attribute currently named spirv and trace its uses across the compiler and GPU code; done means the attribute has a platform-agnostic name and all affected references are updated without breaking existing GPU code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers, computer-graphics
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100