QuantEcon / QuantEcon/lecture-python-programming.zh-cn
No Netlify PR preview for this edition — reviewers have no rendered page to check
Nessuno ha ancora preso questa issue.
- Lingua principale
- Python
- Stelle
- 0
- Fork
- 2
- Merge medio
- 41m
- PR unite (30g)
- 3
Descrizione
What is missing
This is the only edition in the lecture-python-programming series without a Netlify PR preview. The English source, .fa and .fr all deploy one per pull request; this repository's ci.yml has no Netlify step, and gh api repos/.../actions/secrets returns no NETLIFY_SITE_ID here, where .fa and .fr both have one.
Why it matters here specifically
Translation review depends on reading rendered pages. A reviewer working through a sync PR in .fa or .fr can open the preview and see the lecture as a reader will; here they can only read the diff.
It has already cost us twice in the last day:
- #80 — the language switcher plus five URL fixes — merged on weaker evidence than its
.faand.frcounterparts. Both of those were verified against a real deploy preview; this one could only be checked with a local build and a passing CI run. - #81 — the bump to theme 0.21.0 — carries a documented layout change at 1024–1499px viewports, exactly the kind of change that wants a rendered page. There is nothing to look at.
What is needed
Two halves, and the first is the blocker:
- A Netlify site for this repository, and its
NETLIFY_SITE_IDas a repo secret.NETLIFY_SITE_IDis per-site and set at repo level —.faand.freach carry their own — so it cannot be inherited from the org. This step needs someone with Netlify and repo-admin access. - The workflow step in
ci.yml. Small, and copyable from a sibling.
One decision to make first
The series currently uses two different mechanisms, so this should follow whichever is intended as the standard rather than adding a third data point:
| Repo | Mechanism |
|---|---|
| lecture-python-programming (source) | nwtgck/actions-netlify@v4 |
.fa |
nwtgck/actions-netlify@v4 |
.fr |
quantecon/actions/preview-netlify@v0.8.0 |
.fr is the most recently set up of the three and uses the QuantEcon-maintained wrapper, which suggests that is the newer house pattern — but it is worth confirming rather than inferring from one data point. Note also that the .fr preview posts a PR comment rather than a commit status, so it does not appear in gh pr checks; whichever is chosen, that difference is worth knowing.
Happy to write the ci.yml half once the site and secret exist and the mechanism is settled.
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Confronta i passaggi del workflow in ci.yml con i repository .fa e .fr affini, inclusa la loro azione Netlify e la configurazione del secret NETLIFY_SITE_ID. Prima conferma quale meccanismo di anteprima sia lo standard previsto; quindi, una volta che il sito e il secret del repository esistono, aggiungi il passaggio a ci.yml. Il lavoro è completato quando una pull request produce un’anteprima Netlify renderizzata che i reviewer possono aprire.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- github-actions
- Ambito
- ci-cd, devops
- Tipo di issue
- Funzionalità
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Tranquilla
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100