QuantEcon / QuantEcon/lecture-python-programming.zh-cn

No Netlify PR preview for this edition — reviewers have no rendered page to check

Abierto
#82 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
Python
Estrellas
0
Forks
2
Merge medio
41 min
PR fusionados (30 d)
3

Descripción

What is missing

This is the only edition in the lecture-python-programming series without a Netlify PR preview. The English source, .fa and .fr all deploy one per pull request; this repository's ci.yml has no Netlify step, and gh api repos/.../actions/secrets returns no NETLIFY_SITE_ID here, where .fa and .fr both have one.

Why it matters here specifically

Translation review depends on reading rendered pages. A reviewer working through a sync PR in .fa or .fr can open the preview and see the lecture as a reader will; here they can only read the diff.

It has already cost us twice in the last day:

  • #80 — the language switcher plus five URL fixes — merged on weaker evidence than its .fa and .fr counterparts. Both of those were verified against a real deploy preview; this one could only be checked with a local build and a passing CI run.
  • #81 — the bump to theme 0.21.0 — carries a documented layout change at 1024–1499px viewports, exactly the kind of change that wants a rendered page. There is nothing to look at.

What is needed

Two halves, and the first is the blocker:

  1. A Netlify site for this repository, and its NETLIFY_SITE_ID as a repo secret. NETLIFY_SITE_ID is per-site and set at repo level — .fa and .fr each carry their own — so it cannot be inherited from the org. This step needs someone with Netlify and repo-admin access.
  2. The workflow step in ci.yml. Small, and copyable from a sibling.

One decision to make first

The series currently uses two different mechanisms, so this should follow whichever is intended as the standard rather than adding a third data point:

Repo Mechanism
lecture-python-programming (source) nwtgck/actions-netlify@v4
.fa nwtgck/actions-netlify@v4
.fr quantecon/actions/preview-netlify@v0.8.0

.fr is the most recently set up of the three and uses the QuantEcon-maintained wrapper, which suggests that is the newer house pattern — but it is worth confirming rather than inferring from one data point. Note also that the .fr preview posts a PR comment rather than a commit status, so it does not appear in gh pr checks; whichever is chosen, that difference is worth knowing.

Happy to write the ci.yml half once the site and secret exist and the mechanism is settled.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Compara los pasos del workflow en ci.yml con los repositorios hermanos .fa y .fr, incluida su acción de Netlify y la configuración del secret NETLIFY_SITE_ID. Primero confirma qué mecanismo de vista previa es el estándar previsto; después, una vez que existan el sitio y el secret del repositorio, añade el paso de ci.yml. Se considera hecho cuando un pull request produce una vista previa de Netlify renderizada que los revisores pueden abrir.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github-actions
Área
ci-cd, devops
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.