PyGithub / PyGithub/PyGithub

Do I need to hardcode my own GPG keys for new UserGPGKey class?

未关闭
#2,957 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
Python
星标
7.8k
派生
1.9k
平均合并
17 分钟
30 天内合并 PR
2

描述

Background

I'm developing a UserGPGKey class to expose this library to GitHub's REST API endpoints for GPG keys. The UserGPG class is moduled similar to the already-existing UserKey class. The necessiary modifcations have been made to NamedUser and AuthenticatedUser in order to access GPG keys after authentication.

Problem

In the tests of UserKey, AuthenticatedUser, and NamedUser tests, there is information provived on some SSH keys which from my understanding comes from @jacquev6. Here are screenshots from the codebase showcasing what I am refering to:

tests/UserKey.py
image

tests/AuthenticatedUser.py
image

tests/NamedUser.py
image

What I'd like to know is if I'd need something similar and hardcode information from my own GPG key(s) into the testing code for UserGPGKey?

If possible, I'd like to avoid doing this for privacy reasons.
Thanks in advance for reading this rather lengthy issue! 😅

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先查看 tests/UserKey.py、tests/AuthenticatedUser.py 和 tests/NamedUser.py,以了解现有的密钥 fixture 和访问模式。然后将这些模式与提议的 UserGPGKey 类及其对 NamedUser 和 AuthenticatedUser 的更改进行比较;done 应包括适当的测试,且不需要 contributor 的私有 GPG 密钥数据。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
api, testing
Issue 类型
功能
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
需要澄清
新手友好度
28/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。