Project-MONAI / Project-MONAI/tutorials

Explicit for-loop optimisation or SupervisedTrainer

未关闭
#16 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

question
主要语言
Jupyter Notebook
星标
2.5k
派生
803
平均合并
6 天 22 小时
30 天内合并 PR
3

描述

It seems that in the majority of tutorials, the optimisation for loop is given explicitly. In relatively few places, the SupervisedTrainer is used, despite existing for this reason.

I can see why having the explicit for loop is beneficial for tutorials - so that people are more aware of the inner workings. However, for the sake of conciseness, I would be in favour of having just one notebook (named suitably) in which the explicit for loop is given, and then from there on, using the SupervisedTrainer. Notebooks using SupervisedTrainer could then refer to the explicit notebook.

I think @ericspod is in favour of leaving the notebooks as they are, so as not to hide anything (which I understand). Anyone else have an opinion?

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

检查使用显式优化循环和 SupervisedTrainer 的教程 notebook,然后比较它们在教学中的作用。决定是否应保留一个 notebook 中的显式循环,而让其他 notebook 引用它;当教程集合遵循所选的一致方法时,即视为完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
jupyter-notebook, pytorch
领域
documentation, machine-learning
Issue 类型
文档
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。