Void[] breaks the parser before even invoking anything

Open
#5,120 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
csharp
Domain
cli

Research direction

Start by reproducing the reported key sequence, void[], and trace the failure at System.Management.Automation.Language.ArrayTypeName.GetReflectionType() through SymbolResolver.VisitArrayTypeName. Check how the parser handles the invalid array type before invocation; done means completing void[] no longer crashes PSReadLine and behaves gracefully.

Written by the indexing model from the issue text.

Description

Needs-Triage :mag:
Prerequisites
  • Write a descriptive title.
  • Make sure you are able to repro it on the latest released version
  • Search the existing issues, especially the pinned issues.
    • Similar to #4324
Exception report
Oops, something went wrong.
Please report this bug with ALL the details below, including both the 'Environment' and 'Exception' sections.
Please report on GitHub: https://github.com/PowerShell/PSReadLine/issues/new?template=Bug_Report.yaml
Thank you!

### Environment
PSReadLine: 2.4.5
PowerShell: 7.6.0
OS: Microsoft Windows 10.0.26220
BufferWidth: 291
BufferHeight: 80

Last 7 Keys:

 [ v o i d [ ]

### Exception

System.TypeLoadException: Could not create array type 'System.Void[]' from assembly 'System.Private.CoreLib, Version=10.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' because the element type is System.Void.
   at System.RuntimeTypeHandle.MakeSZArray()
   at System.RuntimeType.MakeArrayType()
   at System.Management.Automation.Language.ArrayTypeName.GetReflectionType()
   at System.Management.Automation.Language.SymbolResolver.VisitArrayTypeName(ArrayTypeName arrayTypeName)
   at System.Management.Automation.Language.SymbolResolver.VisitTypeExpression(TypeExpressionAst typeExpressionAst)
   at System.Management.Automation.Language.TypeExpressionAst.InternalVisit(AstVisitor visitor)
   at System.Management.Automation.Language.CommandExpressionAst.InternalVisit(AstVisitor visitor)
   at System.Management.Automation.Language.PipelineAst.InternalVisit(AstVisitor visitor)
   at System.Management.Automation.Language.StatementBlockAst.InternalVisit(AstVisitor visitor, ReadOnlyCollection`1 traps, ReadOnlyCollection`1 statements, AstVisitAction action)
   at System.Management.Automation.Language.NamedBlockAst.InternalVisit(AstVisitor visitor)
   at System.Management.Automation.Language.ScriptBlockAst.InternalVisit(AstVisitor visitor)
   at System.Management.Automation.Language.Ast.Visit(AstVisitor astVisitor)
   at System.Management.Automation.Language.SymbolResolver.ResolveSymbols(Parser parser, ScriptBlockAst scriptBlockAst)
   at System.Management.Automation.Language.ScriptBlockAst.PerformPostParseChecks(Parser parser)
   at System.Management.Automation.Language.Parser.ParseTask(String fileName, String input, List`1 tokenList, Boolean recursed, ParseMode parseMode)
   at System.Management.Automation.Language.Parser.ParseInput(String input, String fileName, Token[]& tokens, ParseError[]& errors)
Screenshot
Image
Environment data
PS Version: 7.6.0
PS HostName: ConsoleHost (Windows Terminal)
PSReadLine Version: 2.4.5
PSReadLine EditMode: Windows
OS: 10.0.26100.7934 (WinBuild.160101.0800)
BufferWidth: 291
BufferHeight: 80
Steps to reproduce

First: Yes, Void[] is an illegal type in .net, since void can't be an array member.

However, it seems the parser is unable to gracefully handle it, in some cases (such as the above sequence).

It fails every time if entered as above, and in several other permutations I tried, such as using arrow keys to go back and edit the brackets in...But only in certain cases.

However, it also behaves slightly differently if there is already something else in the history buffer, AND it loses part of the key buffer in those cases, making the report misleading if taken directly. I played around with it a bit to try to suss out the specifics, but then figured that is probably pointless, since solving the root problem will almost definitely solve those cases at the same time, so gave up on that.

Expected behavior

Shouldn't die so quickly like this. Should be more graceful and not until invocation.

Actual behavior

Dies immediately on the keypress that completes the void[] type name.

Dominant language
C#
Stars
4.4k
Forks
341
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/PSReadLine

All issues in PowerShell/PSReadLine

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.