Void[] breaks the parser before even invoking anything
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Accessibilité débutants
- 55/100
Piste de recherche
Start by reproducing the reported key sequence, void[], and trace the failure at System.Management.Automation.Language.ArrayTypeName.GetReflectionType() through SymbolResolver.VisitArrayTypeName. Check how the parser handles the invalid array type before invocation; done means completing void[] no longer crashes PSReadLine and behaves gracefully.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Prerequisites
- Write a descriptive title.
- Make sure you are able to repro it on the latest released version
- Search the existing issues, especially the pinned issues.
- Similar to #4324
Exception report
Oops, something went wrong.
Please report this bug with ALL the details below, including both the 'Environment' and 'Exception' sections.
Please report on GitHub: https://github.com/PowerShell/PSReadLine/issues/new?template=Bug_Report.yaml
Thank you!
### Environment
PSReadLine: 2.4.5
PowerShell: 7.6.0
OS: Microsoft Windows 10.0.26220
BufferWidth: 291
BufferHeight: 80
Last 7 Keys:
[ v o i d [ ]
### Exception
System.TypeLoadException: Could not create array type 'System.Void[]' from assembly 'System.Private.CoreLib, Version=10.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' because the element type is System.Void.
at System.RuntimeTypeHandle.MakeSZArray()
at System.RuntimeType.MakeArrayType()
at System.Management.Automation.Language.ArrayTypeName.GetReflectionType()
at System.Management.Automation.Language.SymbolResolver.VisitArrayTypeName(ArrayTypeName arrayTypeName)
at System.Management.Automation.Language.SymbolResolver.VisitTypeExpression(TypeExpressionAst typeExpressionAst)
at System.Management.Automation.Language.TypeExpressionAst.InternalVisit(AstVisitor visitor)
at System.Management.Automation.Language.CommandExpressionAst.InternalVisit(AstVisitor visitor)
at System.Management.Automation.Language.PipelineAst.InternalVisit(AstVisitor visitor)
at System.Management.Automation.Language.StatementBlockAst.InternalVisit(AstVisitor visitor, ReadOnlyCollection`1 traps, ReadOnlyCollection`1 statements, AstVisitAction action)
at System.Management.Automation.Language.NamedBlockAst.InternalVisit(AstVisitor visitor)
at System.Management.Automation.Language.ScriptBlockAst.InternalVisit(AstVisitor visitor)
at System.Management.Automation.Language.Ast.Visit(AstVisitor astVisitor)
at System.Management.Automation.Language.SymbolResolver.ResolveSymbols(Parser parser, ScriptBlockAst scriptBlockAst)
at System.Management.Automation.Language.ScriptBlockAst.PerformPostParseChecks(Parser parser)
at System.Management.Automation.Language.Parser.ParseTask(String fileName, String input, List`1 tokenList, Boolean recursed, ParseMode parseMode)
at System.Management.Automation.Language.Parser.ParseInput(String input, String fileName, Token[]& tokens, ParseError[]& errors)
Screenshot
Environment data
PS Version: 7.6.0
PS HostName: ConsoleHost (Windows Terminal)
PSReadLine Version: 2.4.5
PSReadLine EditMode: Windows
OS: 10.0.26100.7934 (WinBuild.160101.0800)
BufferWidth: 291
BufferHeight: 80
Steps to reproduce
First: Yes, Void[] is an illegal type in .net, since void can't be an array member.
However, it seems the parser is unable to gracefully handle it, in some cases (such as the above sequence).
It fails every time if entered as above, and in several other permutations I tried, such as using arrow keys to go back and edit the brackets in...But only in certain cases.
However, it also behaves slightly differently if there is already something else in the history buffer, AND it loses part of the key buffer in those cases, making the report misleading if taken directly. I played around with it a bit to try to suss out the specifics, but then figured that is probably pointless, since solving the root problem will almost definitely solve those cases at the same time, so gave up on that.
Expected behavior
Shouldn't die so quickly like this. Should be more graceful and not until invocation.
Actual behavior
Dies immediately on the keypress that completes the void[] type name.
- Langage dominant
- C#
- Étoiles
- 4.4k
- Forks
- 341
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de PowerShell/PSReadLine
-
Needs-Triage :mag:
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
PowerShell/PSReadLine#5205 ·
-
Needs-Triage :mag:
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
PowerShell/PSReadLine#5195 ·
-
Needs-Triage :mag:
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
PowerShell/PSReadLine#5121 ·
-
Needs-Triage :mag:
Difficulté 2/5 1-3 heures Accessibilité débutants 64/100
PowerShell/PSReadLine#5045 ·
-
Area-CommandHelp Issue-Enhancement
Difficulté 1/5 Moins d'une heure Accessibilité débutants 68/100
PowerShell/PSReadLine#3470 · 3 réactions ·
Toutes les issues de PowerShell/PSReadLine
Issues similaires
-
bug documentation frontend
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
azurenoops/spin_agent#975 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulté 2/5 1-3 heures Accessibilité débutants 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
SubtitleEdit/subtitleedit#15108 · 1 commentaire ·
-
area/docs-content Bug pulumi/docs
Difficulté 1/5 1-3 heures Accessibilité débutants 94/100