Configurations for the new color/style used in metadata line and warning for the scrollable list view

Open
#3,584 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
cli

Research direction

Start by reading the discussion linked from the issue and the six existing comments to understand the unresolved configuration options for the metadata line and scrollable list warning. No files or tests are named, and the issue is complete only once the project has an agreed configuration design and corresponding implementation scope.

Written by the indexing model from the issue text.

Description

Area-Predictors Issue-Enhancement Needs-Triage :mag:
Prerequisites
  • Write a descriptive title.
Description of the new feature/enhancement

This issue is to follow up on https://github.com/PowerShell/PSReadLine/pull/3583#discussion_r1109181920, the discussion about what to make configurable about the new color and styles used in the metadata line and warning for the scrollable list view.

About the new colors and styles, there are a few of them:

  • un-highlighted texts in the metadata line
    • currently, the un-highlighted text uses the default inline view color/style -- this is fixed as of today.
  • highlighted text in the metadata line
    • currently, the highlighted text uses the ListPredictionColor plus italics -- so, it partially configurable.
  • warning message
    • currently, the warning message uses the ListPredictionColor plus italics.

I'm not sure about what to expose for configuration yet. It doesn't seem needed to expose them all in my opinion. The following are my thoughts at the moment:

  1. always apply italics to the text rendered in the metadata line, and use the ListPredictionColor as the user-configurable highlighting color/style.
  2. maybe expose configuration for un-highlighted text color/style, but I'm not super sure if it's really needed.
  3. warning message will be uncommon for users to see because it will happen usually only when the terminal height is very small (<5). So, exposing a configuration for it seems overkill to me.

I don't have a clear idea what/how to make configurable about the new color/styles at the moment, so I prefer to wait and collect some feedback about this, which hopefully will give us a clearer idea.

Dominant language
C#
Stars
4.4k
Forks
341
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/PSReadLine

All issues in PowerShell/PSReadLine

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.