PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

New General's Cry DPS calculation for Lacerate of Butchering is not consistent with in-game testing

Open
#9,825 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

From my in-game testing, increases and reductions on attack speed have no noticeable effect on DPS for General's Cry with Lacerate of Butchering. I compiled an infographic that shows this - under screenshots.

What is the value from the calculation in Path of Building?

The new (2.64.0?) DPS calculation for General's Cry with Lacerate of Butchering (and possibly other skills) has a strong correlation with attack speed.

How to reproduce the issue
  1. Select Lacerate of Butchering as the Main Skill
  2. Apply any source of increased attack speed
  3. See DPS increase that does not exist in game
PoB for PoE1 build code
https://pobb.in/44iRBO-9WJhm
Screenshots
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Load the provided PoB build code and reproduce the General's Cry setup with Lacerate of Butchering. Compare attack-speed changes against the in-game evidence and trace the DPS calculation that responds to them. Done means the calculation no longer shows an attack-speed DPS increase that is absent in-game.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.