PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Local impale chance should not apply per hand for skills like Dual Strike

オープン
#9,737 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

bug: calculation
主要言語
Lua
スター
5.4k
フォーク
2.4k
平均マージ
1日 12時間
マージ済み PR(30日)
26

説明

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

Impale is an on-hit effect that isn't part of damage calculation; it occurs after skills like Dual Strike have combined their damage from both hands. The combined hit receives local impale chance from both weapons, unlike local chance to poison or bleed.

With 60% global impale chance and 20% local impale chance on both weapons, Dual Strike has 100% chance to impale. Here's a (painful) demonstration of that setup successfully impaling for 270 consecutive hits, which makes it vanishingly unlikely for the chance to be 80% (or even 96%).

(Mechanically, the same applies to other local chance stats for on-hit debuffs that aren't damaging ailments, such as Maim or Blind, but those two are currently not implemented in PoB.)

What is the value from the calculation in Path of Building?

Skills that combine damage from both hands do not combine impale chance from both hands.

This affects all skills that combine damage and can be used while dual wielding.

How to reproduce the issue
  1. Add Dual Strike
  2. Add Impale Support
  3. Add a sword with the local impale chance benchcraft, slide it to 20%, and equip it in both hands
  4. Observe that each hand calculates impale damage with 80% chance to impale (and that additional impale chance still raises impale DPS)
PoB for PoE1 build code
eNq1XGtv27gS_dz8CsHAArvA1pblZwJnF06cF5A0vnba3vupYCTa5oYSXYlK4l30v--QlGTZNWXK8k2BxpLmnOEMOcOHxhn8-e5T6xWHEWHBea1Zt2sWDlzmkWB-Xvv8dP2xX_vzj5PBGPHF4-wiJlQ8-ePkw0B-tnxEgilzXzC_CVm8BIaaRfErpvLTK8FvD8zD57W7h_Hj5KlmPaPAI_y89okFuGa5FEXRJ-SDwNSFBtQsFLk48C7X95UgR-Ec8y9pM1vfoJlLFPAFZsED-ouFN8xLZbP7JNi47y5QiFyOw3vRvmHMmWoaD2NcA4s-DMYUrXA45YhbEfx3XhuCY9Acj5AP_4M5iMYAaHbrzZ7d7Pc6tUYh7iIOI74F7tftfsc-benB0yXG3lpZ3e71daLjEF_NZtjl5BVfhoRfLlDgrnVpVeyQtetOofhDTDlZUoLDXNO0iFvztjwxjuhoPF3T9urtVrPddZrOHhDj6-brJL8Svrig4NGyKgTwbh4Qjg9BjhmJWHCoWXmc1rI7f4noRuP69VOnfWr3u3a_0KqfgE633up0Wz2712ppB0FMKYS-UdMmOMLhK-Jk0wVa-UvmP5Ngs49M2vSAAnTJovUwaPaLRMc4hOzCNxD2HsAUuwwS0oaS03rbbhso2g3XarwnM2wuWcqYBFC2NYfZcTU1lStNfFiDJpCAzSSnLKaGknydCJ2CQPieF2w2T3WSI_xuxpcXLOC7C7gB3wi_Mi4n3n32ytR0dTvOJNutuu20up2W3ek6pz3tFLVYRcRF9AG9Ez_2YWJ4Qi94rbBbMADnCx5AytFBW1ql1yTE5VGXjHoHoBaIRVpYQT4iwS0shoauG8OyZLX2q9Yhj7NZSYSIYQNPw4rDPROyd4Frlhg-B6FM8bmFSrcQMIFwFYuiZ4oNEWsVSdCvR729R9UcB4m-lZk59xi7ixvokQni2GxqWC9sit0qZI3cKgR3uLVjCCjhJAHUOKl-WgQq6aarAIfz1XRBMPXKSacNu0RLg0ws3JxHG7l7U12pEZOHlnTJVxR6ZvNV2Ta9oiifx5vdYncpcbOBiWH5DAAPb28Z9NsS9pfYlNBysGHoszg07HAlbGRAOgWpndgEe7FrNudle6sLClvcLTOc_TBoKKW7sHoXcI7clxHz5sZek0pKITbbN42XS0giYjiYEojpFZb4JLdO-tg1kH6EsWwU0mImNlewljZWkK0tzLVsQcxtEeuDEsasxY1VZB36ANnCh1lAHiE8sNwpgrZzYFdntEWTgoY70zF7g5YvxJlNVE4a1lHrtZO2KSEO_l4Z82-IGym4CjxYYUEoGOvYRuxS80R8yKRRNEIcWV6y8P6CQoIC3pTHZVs3HXkzwih0F_cwHs5r-atrROkzJAu4K_gHDXkgJz49hRhbKI1wV7DIBogLK2AejmBZ0e_DtlodwN15wjKLAyx3wub0hTaxyULharg-lhPSAaE1y0cRh7lJDb5INA5tStlS7YfB58m9_PBhwfkyOms03t7e6kvEF2yG32GSqLvMbywBBA3-GL0QSj-KtjSG8HMxH8ofSdRImQbqyDFqqCsRKCEBu5SjG8JQ6RLhidQjXwh-s_5mzL9Xx5Ngvbj6L0Rjpwcbevu012t1u06nox78Dx44tl23O-2O0-21-7DHsaIFexPdPiJgNYwrV_hSHiAmPQO7vbRDpsKSCDp1hmLKb7D_nxhRwlfS2YLoHs9hGQ8PgGOGaIRrOeGklQEL_WzzpGBDyhOmDWjEQoGLLlYQo2mjklEgWjLFXI2nvNy1WMNsnb9IG2FSUHJPq6WwcXh_nwyihMsiXjqwkpvyLHi4VqjOgtGzMEMcKou1v5c2bEv2ElE3kgASuDT2YCeSZCY12NT4GUB7rDn2xeB6wBx5EEmNOw7GNIRFDUkFn0bgHugI8oJTvTeUPSPqpNrzN5vpze_KqYJ8pLoB4oPFAc8fasOsbwXITwJLKLJSTXLkSnRO_fdcn7-qsN4W2fRMw9DUrIPUad7_2dBUSWZjoj-9rzFzS2qXpQPVa0ngJoNLBq-KH_ER8MBi4Xfxa4xCoUiNehlo0i3JUBef05EeR1idEn3FaMkCeVtmLn0Uy2YIjvzwnoBBfHVmTYaTq5NPkEWEwMkTmePQumXs5eQyRDOOvTNLcJyMQzwj72eWeOtQcDGNZyYXSaifWY59kmS9M-vmI_w7kSligr-fWT37BHxEiUvE0-bJPxzNozMkF5M_HPsX8e4DrLQ4sx4Q8S0WWLeEJ2LLZHn8zZPr49_j4BVDVva--cz7PbmXyvyecP7jKpN__AOz3hyf2fXOj19POx-bdue3X0QMhxhF2LPSpbel1t5H1Nj88WuzDwn6t7xxaqBZsEHzCY4SM603wheWWllHcsjBymgiSCxJJba9kPNVhyeDUivh6CSa6nk62ctYzUaTyJfa0biRSCnjMuzOaxdYxCUB9PgZ5j2RQ8WFmlgbP4lfw6z7YjVLI5zSiFZpRLsEQnnHalrTN7H0LYtzyuJuxLAq5TeFKO-3TgnE0I8p5geYr4E0d0AumLey0j23ufUU9hjRoR1qDZ9XUSQmTZnKSvn9gjF-NMVlum8Cm75SLS3U3Cqr2TmW5nZZza1jae4cQFRiJBfq7pbQfYupf0jYNauMax2HcwSO1hE42kfg6ByBo3vobHCEznEqJ5FCotaxiNrHIuoci-igXjtGhx2jr47RTcfooWN0TuW0WKVXdjM4lRlalRnalRk6lRm6pVZB2aqt2mJKS-Mch6Z1HJr2cWg6x6Hpll4pV-mk3QxOZYZWZYZ2ZYZOZYZu2b1D5c1HtUjZQdCqStCuStCpSlCqFzCtNIvswjsV8a2K-HZFfKcifo__1UFUeqQqT0rFJ3nero6ngmWc8vskcr89x7OZKIyuWREPZRX41fX11eXT3ZerhDIPkQfC34LYfxaFwer3-nXjFMs37VYUP0fq43lNvIeRR7sjzBGhkTh7phQtI3EwnLzLEEdiyVkwBVwBm5S6JVmV9W6utYCe6eodhxzs_YpCNyRY267s-Z5GKYWifEO8-NOxiRpmPZE6tLxEEVflJRpPyYJxPYso39aaIx4WYNOj-93g5OkeT3DxCmmJXTIjrjh2L-5y8cJJSRX4JSuB0_Z3Usug55BF4ToC9VAPVuXdOnTytMCrsq5c61X1VA8fYRdpbVcP9eCsYokF4CYdSyZVwPSJBXKQQ9AMCRV1B9qevaI4E9ETPvIFDpP3yTqmB8hRqUhh4ITkOeb6MM5JFPhK1k9qPCSe6aGqRlBjg3hWkIk26uY0Ds3L6KlUvZk2kRVBVQ2K1n9JRUtBFyQnyxr3q6cFTkgL2jT2J48LgkTm3-ErI56qatKEy5ZYUcKAGbc6jSzVqk6zXbtVnVG-pdD2d_JUD__MiXhRuYNFvXU2IhFBVY1BxFY1hicSuDwO8cEEk-2VyBo7KV6DZPVGO8Hp06LMkZQhHcygiqUOhstaroPRMv-P8Ey-kS-aADKZAkMYrOZgwYF4QXAYck15HIzAsUegkibuTkprT5XiUtPqTq-VZlTJIvkKQ1E-USJ7iGBdcFuw8jRjymobbzGi4nt1jFYj_OmrGlXIRIF2vESBl9I97lrvr_vB0HuwzwZOWdA3EnXgVX0YYH-1g0jfrkEj3SEOPjFYIwlqcTe9GMgqHMvDEWyZUDLhU-gZtFziYN3GqahX817FWH-Cnos26nYuWTAj86RwR10kpTvSkuzORoXEmCIXLxj1cJhuQcmc0MeZTD2wcZD5c2sjuguGhVM2S8PXOMdp74Nm9cAHYEXF8gGwfN11CuvY-3SJguJtZf3TrkETy-iaukyWP4oiG3P__1SHbW4W3BmL8E0RLRM_bKtp7VOTrmJTQLd52j_VY1w1ZmGzy0NEZYnYpaisyxm2R2HyJQUIUlletAb29jU1WzFnzreb7ZbBkDJ1o599BVx8ixiH2JPdLQ2cYjrLae6Y9nt53TKZ3SJK2RvgYTHmY6PxJoqv8Qh6X028xk0VHjokPYjivFzAtfXyy-zrMj83r22b-GTTHSoIJ9hnr9i7WEFeXhl5CJK1-1I2gpO_VrAepXsDN_e3B0yDQmC2-6CVnXBmE4WauOTVHyeDxvbfrPgXOjZn4g==
Screenshots

No response

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

まず、Impale chance の計算箇所と、両手からのダメージを組み合わせるスキルの処理を特定し、次に上記で説明されている Dual Strike セットアップで問題を再現します。完了条件は、combined-hit スキルが両方の装備武器のローカルな Impale chance を使用し、表示される Impale ダメージがゲーム内の挙動と一致することです。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
lua
領域
backend
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
静か
明瞭さ
おおむね明確
初心者へのやさしさ
64/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。