PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

The Will of Xoph, Esh, Tul, Uul-Netol, and The Sundered Will ring aura effects not calculated correctly.

Aperta
#9,721 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

bug: calculation
Lingua principale
Lua
Stelle
5.4k
Fork
2.4k
Merge medio
1g 12h
PR unite (30g)
26

Descrizione

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

These 5 rings which give you increased aura effect of their respective damage types is not calculating the increased aura effect correctly.

PoE calcs it by taking the total sum of increases in the damage type then multiplying it by the ring mod (10-15%) to get the increased aura effect.

What is the value from the calculation in Path of Building?

What PoB is doing is multiplying each fire damage node by the mod value and rounding down.

This means

  1. Any node that maths out to <1 is rounded down and discarded. So any light of meaning nodes are not counted.
  2. All nodes are counted individually and rounded, which will drastically alter the final sum.
How to reproduce the issue

Example:

using the character from the first PoB below. I went into PVP with a friend to see his resistances from my flammability aura.

I have found that while pob says 618% fire damage, it was adding together the elemental damage from other parts of the tree. My true increased fire damage is 430% increase fire damage

Image

With no ring or any other modifiers to curse effect (Including on target)
Gem base effect -38 to fire resistance
Blasphemy aura: 25% less curse effect
Expected effect: 38*0.75 = -28 to fire resistance
Actual test: Target went from 37% fire res to 9% fire res. As expected.

Putting on a 15% will of xoph
Gem base effect -38 to fire resistance
Blasphemy aura: 25% less curse effect
Will of xoph aura effect: 430% * 0.15 = 64.5%
Expected effect: 38 * 1.64 * 0.75 = 46%
Actual test on target: Target went from 37% fire res to -9% fire res. losing exactly 46%

Conclusion: Poe sums all increases to fire damage before applying the ring multiplier.

PoB where I noticed the error

https://pobb.in/zBPqbSTWQ5do

PoB where I tested all 5 rings using 1 ring with all the mods, and a light of meaning with all the damage types.

https://pobb.in/1evKsFjeHOuN
Screenshots

No response

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia riproducendo i calcoli dell’aura dell’anello segnalati con i due esempi PoB collegati e confrontali con i risultati delle resistenze nel gioco. Traccia come vengono aggregati e applicati al moltiplicatore dell’aura di ciascun anello i danni aumentati da fuoco, freddo, fulmine, fisici e caos; il lavoro è completo quando tutti e cinque gli effetti degli anelli corrispondono ai calcoli attesi indicati.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
lua
Ambito
backend
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
55/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.