PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

The Will of Xoph, Esh, Tul, Uul-Netol, and The Sundered Will ring aura effects not calculated correctly.

Offen
#9,721 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

bug: calculation
Vorherrschende Sprache
Lua
Sterne
5.4k
Forks
2.4k
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
26

Beschreibung

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

These 5 rings which give you increased aura effect of their respective damage types is not calculating the increased aura effect correctly.

PoE calcs it by taking the total sum of increases in the damage type then multiplying it by the ring mod (10-15%) to get the increased aura effect.

What is the value from the calculation in Path of Building?

What PoB is doing is multiplying each fire damage node by the mod value and rounding down.

This means

  1. Any node that maths out to <1 is rounded down and discarded. So any light of meaning nodes are not counted.
  2. All nodes are counted individually and rounded, which will drastically alter the final sum.
How to reproduce the issue

Example:

using the character from the first PoB below. I went into PVP with a friend to see his resistances from my flammability aura.

I have found that while pob says 618% fire damage, it was adding together the elemental damage from other parts of the tree. My true increased fire damage is 430% increase fire damage

Image

With no ring or any other modifiers to curse effect (Including on target)
Gem base effect -38 to fire resistance
Blasphemy aura: 25% less curse effect
Expected effect: 38*0.75 = -28 to fire resistance
Actual test: Target went from 37% fire res to 9% fire res. As expected.

Putting on a 15% will of xoph
Gem base effect -38 to fire resistance
Blasphemy aura: 25% less curse effect
Will of xoph aura effect: 430% * 0.15 = 64.5%
Expected effect: 38 * 1.64 * 0.75 = 46%
Actual test on target: Target went from 37% fire res to -9% fire res. losing exactly 46%

Conclusion: Poe sums all increases to fire damage before applying the ring multiplier.

PoB where I noticed the error

https://pobb.in/zBPqbSTWQ5do

PoB where I tested all 5 rings using 1 ring with all the mods, and a light of meaning with all the damage types.

https://pobb.in/1evKsFjeHOuN
Screenshots

No response

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne damit, die gemeldeten Ring-Aura-Berechnungen mit den beiden verknüpften PoB-Beispielen zu reproduzieren und sie mit den Widerstandsergebnissen im Spiel zu vergleichen. Verfolge, wie erhöhter Feuer-, Kälte-, Blitz-, physischer und Chaosschaden aggregiert und auf den Aura-Multiplikator jedes Rings angewendet werden; die Aufgabe ist abgeschlossen, wenn alle fünf Ringeffekte mit den angegebenen erwarteten Berechnungen übereinstimmen.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
lua
Bereich
backend
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Ruhig
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
55/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.