PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

The Will of Xoph, Esh, Tul, Uul-Netol, and The Sundered Will ring aura effects not calculated correctly.

Open
#9,721 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

These 5 rings which give you increased aura effect of their respective damage types is not calculating the increased aura effect correctly.

PoE calcs it by taking the total sum of increases in the damage type then multiplying it by the ring mod (10-15%) to get the increased aura effect.

What is the value from the calculation in Path of Building?

What PoB is doing is multiplying each fire damage node by the mod value and rounding down.

This means

  1. Any node that maths out to <1 is rounded down and discarded. So any light of meaning nodes are not counted.
  2. All nodes are counted individually and rounded, which will drastically alter the final sum.
How to reproduce the issue

Example:

using the character from the first PoB below. I went into PVP with a friend to see his resistances from my flammability aura.

I have found that while pob says 618% fire damage, it was adding together the elemental damage from other parts of the tree. My true increased fire damage is 430% increase fire damage

Image

With no ring or any other modifiers to curse effect (Including on target)
Gem base effect -38 to fire resistance
Blasphemy aura: 25% less curse effect
Expected effect: 38*0.75 = -28 to fire resistance
Actual test: Target went from 37% fire res to 9% fire res. As expected.

Putting on a 15% will of xoph
Gem base effect -38 to fire resistance
Blasphemy aura: 25% less curse effect
Will of xoph aura effect: 430% * 0.15 = 64.5%
Expected effect: 38 * 1.64 * 0.75 = 46%
Actual test on target: Target went from 37% fire res to -9% fire res. losing exactly 46%

Conclusion: Poe sums all increases to fire damage before applying the ring multiplier.

PoB where I noticed the error

https://pobb.in/zBPqbSTWQ5do

PoB where I tested all 5 rings using 1 ring with all the mods, and a light of meaning with all the damage types.

https://pobb.in/1evKsFjeHOuN
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported ring aura calculations with the two linked PoB examples and compare them with the in-game resistance results. Trace how increased fire, cold, lightning, physical, and chaos damage are aggregated and applied to each ring's aura multiplier; done means all five ring effects match the stated expected calculations.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.