PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

[Request] Add section for "Cost on Cast", for things such as "Sacrafice", Self Damages on Cast/Use, Dark Pact, Forbidden Rite, Energy Shield Cost, Scold's Bridle, etc.

オープン
#9,719 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

enhancement
主要言語
Lua
スター
5.4k
フォーク
2.4k
平均マージ
1日 12時間
マージ済み PR(30日)
26

説明

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Linux - Wine

Is your feature request related to a problem?

Move specific calculations outside of "Skill type-specific Stats" into its own section

Add section for "Cost on Cast", for things such as "Sacrifice", Self Damages on Attack/Cast/Use, Dark Pact, Forbidden Rite, Energy Shield Cost, Scold's Bridle, on Minion Death, etc.

This should separate between:
Sacrifice Amount: (Life, Mana, ES, other) (Note: THIS IS NOT TREATED AS A COST IN PoE. You just lose it.)
Sacrificed Life
Sacrificed Mana
Sacrificed Energy Shield

(Normal Spending Calculations)
Life Cost:
Life Cost per Second:
Mana Cost:
Mana Cost per Second:
ES Cost:
ES Cost per Second:
other(?) Costs:

And further separate between Damage Taken as Type Costs. (Forbidden Rite, Scolds, etc)
Per Use: Physical, Fire, Cold, Lightning, Chaos
Total: Physical, Fire, Cold, Lightning, Chaos
This Total Cost section needs to take into account Attack/Cast speed, and total "Repeat" Count from sources like Spell Echo or Unleash Seals.
(Ex: 1 Cast + 4 Seals = 5 Total Casts.)

You may need to further separate this between (Life Taken, ES Taken, Mana Taken) because things can split damage between groups, such as Mind over Matter, Ivory Tower, 33% of Chaos damage does not bypass energy shield, 50% of all damage bypasses energy shield, etc.
This would be extremely helpful to have.

So for example, one can split Forbidden Rite Self damage between (30% Life, 40% mana, 30% ES) with use of Mind over Matter and ES Masteries.

Why add this section?
This came about as a need for myself to calculate self damage on every Forbidden Rite Cast, but having to use the Enemy Damage Configuration to simulate self damage, while setting all other damage types to zero.
It is increasingly clunky and obtuse to have to configure every time something changes, like Life Totals, ES totals, or resistances.
This is further exasperated because these modifiers show up in different sections of PoB when trying to find them.

The Damage you take from Forbidden Rite can be verified with In-Game Tooltip.
"Take # Chaos Damage"

Sacrificed amount from things like Dark Pact cannot be verified with Tooltip, and PoE has bad wording for this skill.

Custom Modifier Configs I have tried using.

//testing damage taken per cast for calc config
+200% to all resistances
maximum life is 1500
maximum energy shield is 6000

//why doesnt this work?
maximum mana is 5000
//99% less maximum mana
//HERP DERP
+1369 to maximum mana
32% reduced maximum mana

//works
//Your Skills deal you 400% of Mana Spent on Upfront Skill Mana Costs as Chaos Damage

//doesnt work
Your Skills deal you 40% of Your Maximum Life as Chaos Damage
Your Skills deal you 25% of Your Maximum Energy Shield as Chaos Damage

//works, but counts as additional taken from enemy
//+-350 Chaos Damage taken

//WORKS? doesnt show
//Take 40% of Maximum Life as Chaos Damage
//Take 25% of Maximum Energy Shield as Chaos Damage

//adding condition doesnt work
Take 40% of Maximum Life as Chaos Damage when you cast a spell

//works
Skills cost +100 life
Skills cost +0 mana

//works? but doesnt show
Skills cost +0 energy shield
//Skill Spend 100 energy shield
//DOESNT WORK, AGAIN HERP DERP POB
//Skills Cost 100 Maximum Energy Shield

//wtf is the cost line???
//CUSTOM mod from Whisper of Infinity....
//Skills Cost Energy Shield instead of Mana or Life

Describe the solution you'd like

See Above

Describe alternatives you've considered

No response

Additional context

Fix Custom Modifiers listed?
Add conditionals such as "When you ___" for things like "When you attack", "When you cast a spell", "On Use", etc
"maximum mana is 5000" does not work. Yet using Less/Reduced does.

This new section can be further expanded upon for Minion loopers and self damage taken calculations.
For things like Heartbound Loop, Minion Duration, and physical damage taken per minion death, etc.

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

ファイル、テスト、エントリーポイントのいずれも指定されていません。まず、要求された Cost on Cast、犠牲、支出、受けたダメージ、反復回数、カスタム修飾子の挙動を、範囲を限定した要件に分解します。合意されたスコープと検証済みの計算が必要です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
lua
領域
game-dev
issue の種類
機能追加
難易度
5/5
見積もり時間
1週間以上
活発さ
静か
明瞭さ
説明が足りない
初心者へのやさしさ
25/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。