PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Confusion over physical damage max hit value + Shaper of Flames
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Hey there,
So I'm just messing with my Elementalist build and I'm feeling a little confused to the Max Phys Hit value.
As far as I understand it, with the elemental values, they are basically how much incoming damage you can recieve, before your defenses before you're toast, so (crudely) calculated in reverse from cold damage - cold res == life + ES, would I be right in saying that?
With physical, it just seems to be a component of your life + ES, with reductsion from armour.
The issue I'm seeing here is the use of Shaper of Flames from the elementalist ascendancy, which converts 40% of physical damage they deal to fire damage when they are ignited. If I set "Is the enemy Ignited?" in the config, I would expect the physical max hit to be the incoming value, minus 40% of it, plus 40% of it reduced by my fire resistance, and any armour/other reductions. But this doesn't seem to be the case, the max physical hit doesn't change, and if it's supposed to be the amount of incoming physical damage you can absorb before you die, I don't think this value is representitive.
I don't know if this is me misunderstanding something, or if it's a bug with Shaper of Flames/Ignited Enemy and that value specifically. In the calculations tab, the example of incoming damage does indeed seem to take it in to account, but hovering over Physical Max Hit only shows the raw damage x 0.85, which I think is my armour, toggling the skill doesn't change this multiplier.
I hope someone can clear this up, thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the reported build in Path of Building with Shaper of Flames and the “Is the enemy Ignited?” configuration enabled. Compare the incoming-damage example in the calculations tab with the Physical Max Hit hover value; the issue is resolved when the displayed physical max-hit behavior is consistent with the documented calculation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100