PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Dark pact of thrarthus doesn't take into account if you use traps/mines or not
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
I don't have the in game calculations, but i checked the code, and that is calculating ruin stacks, which do not work when you have traps (max is 1 on the trap) this causes the average to appear as if you're dealing 100 mill dps while in fact you'd do 1 million
What is the value from the calculation in Path of Building?
i checked the code, and that is calculating ruin stacks, which do not work when you have traps (max is 1 on the trap) this causes the average to appear as if you're dealing 100 mill dps while in fact you'd do 1 million
How to reproduce the issue
easiest value to see this change with is the quality setting on thrarthus, this adds damage eventhough it only allows you to stack ruin more quickly. nothing else.
I believe adding another setting along with average and max ruin. would do it
Part 1 = No Ruin
Part 2 = Average
Part 3 = Max Ruin
PoB for PoE1 build code
https://pobb.in/d8v0vUo1Z8Dz
Screenshots
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el problema con el PoB enlazado para el código de build de PoE1 y, a continuación, sigue el cálculo de ruin stacks y su tratamiento de las trampas y las minas. Comprueba cómo afecta el ajuste de calidad de Thrarthus al daño mostrado; el trabajo estará terminado cuando el daño de trampas y minas ya no asuma ruin stacks sin restricciones y las opciones de ruin-state solicitadas estén representadas correctamente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- game-dev
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 38/100