PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Dark pact of thrarthus doesn't take into account if you use traps/mines or not

Open
#9,428 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

I don't have the in game calculations, but i checked the code, and that is calculating ruin stacks, which do not work when you have traps (max is 1 on the trap) this causes the average to appear as if you're dealing 100 mill dps while in fact you'd do 1 million

What is the value from the calculation in Path of Building?

i checked the code, and that is calculating ruin stacks, which do not work when you have traps (max is 1 on the trap) this causes the average to appear as if you're dealing 100 mill dps while in fact you'd do 1 million

How to reproduce the issue

easiest value to see this change with is the quality setting on thrarthus, this adds damage eventhough it only allows you to stack ruin more quickly. nothing else.
I believe adding another setting along with average and max ruin. would do it
Part 1 = No Ruin
Part 2 = Average
Part 3 = Max Ruin

PoB for PoE1 build code
https://pobb.in/d8v0vUo1Z8Dz
Screenshots
Image Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the linked PoB for PoE1 build code, then trace the ruin-stack calculation and its handling of traps and mines. Check how the Thrarthus quality setting affects the displayed damage; done means trap and mine damage no longer assumes unrestricted ruin stacks, with the requested ruin-state choices represented accurately.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.