PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Essence Drain not calculating and showing DPS values
まだ誰も着手していません。
- 主要言語
- Lua
- スター
- 5.4k
- フォーク
- 2.4k
- 平均マージ
- 1日 12時間
- マージ済み PR(30日)
- 26
説明
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
There is a damage per second value shown in game based on the hit damage, cast rate, and critical chance/multiplier, but total poison DPS is not a value the game shows or calculates and is exclusive to Path of Building.
What is the value from the calculation in Path of Building?
For Essence Drain (and Essence Drain of Wickedness) in the Calcs/Skill Details section, selecting the skill as the Active Skill:
-
There is no 'Skill DPS' value or field. It has the Average Hit and Casts per second fields, but going from Soulrend to Essence Drain, the field/line disappears.
-
The Total Poison DPS value is incorrect. It repeats the Poison DPS value. For Soulrend, it has the Poison DPS value multiplied by the Poison Stacks value and when you mouse over the Total Poison DPS value, it shows this calculation (in a green box). When I switch to Essence Drain of Wickedness mousing over the value shows nothing (in the picture provided the mouse cursor doesn't show, but I'm over the Total Poison DPS number in both cases, with one producing the additional calculation pop-up and the other not doing so) and it doesn't multiply the Poison DPS with the Poison Stacks value to get the Total Poison DPS and instead just repeats the Poison DPS value (single stack value). This also means the Full DPS and Full Poison DPS values on the left hand side with all the other overall values for the build is incorrect, significantly lower than it should be.
Basically Soulrend shows these functions/values exist in Path of Building, but aren't working for Essence Drain specifically for some reason, making the total DPS values quite inaccurate. I've been using Soulrend as a substitute in the mean time. Program is great, thanks!
How to reproduce the issue
- Select Essence Drain of Wickedness as main skill
- Go to the Calc's page, see that there is a missing field for Skill DPS and that the Total Poison DPS value is not multiplying the Poison DPS with the Poison Stacks value and there is no mouse-over. At the top of the first damage box it shows (By Skill Hit Damage) the average hit damage, whereas Soulrend shows the DPS value.
Also when you switch between the skills on the left hand side (Main Skill:), Soulrend has a 'Hit DPS' field and 'Combined DPS' field that are both missing for Essence Drain, despite them both doing hit damage, debuff damage over time type damage, and poison damage.
PoB for PoE1 build code
https://maxroll.gg/poe/pob/wr5c70uz
Screenshots
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
Essence Drain of Wickedness をメインスキルとして選択した状態で問題を再現し、その Calcs/Skill Details の出力を Soulrend と比較します。Skill DPS、Total Poison DPS、およびマウスオーバー時の内訳を担当する計算経路を追跡します。Essence Drain が期待される DPS フィールドを表示し、Poison DPS に Poison Stacks を乗算し、全体の Full DPS 値を更新すれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- lua
- 領域
- game-dev
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 45/100