PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Dropdown to manually select trigger skill
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
Currently I'm playing a Holy Relic of Conviction build triggering with Lancing Steel of Spraying (set to All Projectiles Hit).
However I'm using Shield Charge as a movement skill. When that gem is active in PoB, HRoC chooses it as the triggering skill even though this results in a lower trigger rate.
But even if Shield Charge genuinely had a faster hit speed/trigger rate, using that as the skill for the trigger rate calculation doesn't match how I'm actually playing the character.
Describe the solution you'd like
When Summon Holy Relic of Conviction is the Main Skill, or is selected in the Calcs page, the related Minion Skill Nova (or any other triggered skill) should have an additional dropdown below it to select the relevant trigger skill(s) from which to calculate trigger rate.
Describe alternatives you've considered
Currently the only work around is to manually disable the Shield Charge gem so it can't be chosen as the trigger skill.
Additional context
example build where this happens for Holy Relic: https://pobb.in/TxKFGWxPz5gK
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the trigger-rate calculation for Summon Holy Relic of Conviction and the related Minion Skill Nova in the Calcs page. Identify where active skills are selected as triggers; done means the UI lets users choose the relevant trigger skill or skills and the displayed trigger rate uses that selection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100