PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add decimal (float) support for ailment effect in config

Open
#9,072 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

In the config tab, the "effect of ailment" fields do not allow you to input decimals, restricting you to whole numbers.

Describe the solution you'd like

I'd like to be able to specify a decimal rather than being limited to whole numbers. This is mostly relevant for brittle, but might as well do it for the others too.

Ex: Being able to input 2.6 "effect of brittle" instead of having to round to 2 or 3

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the config tab’s ailment-effect input handling and the validation or value-conversion logic it uses. Confirm how the brittle and other ailment fields currently reject decimals, then verify that decimal values such as 2.6 are accepted and preserved for each relevant field.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.