PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Warcries in the Party tab have no effect if the player is also using the same warcries

Abierto
#8,893 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug: behaviour
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

Strongest warcry in-game takes effect.

What is the behaviour in Path of Building?

Warcries in the party tab have no effect if the same skill is used by the player.
Battlemage's cry for example:
Party tab has the following from a Crybot:

--- Battlemage's Cry 257 0.5|Skill:BattlemagesCry|CritChance|BASE|-|-|type=GlobalEffect/div=5/effectType=Warcry/limit=25/warcryPowerBonus=5 ---

The player is also using Battlemage's Cry. If the player has skill enabled, the Crybot's superior Battlemage's Cry, with all that crit, is not used. If the player unchecks Battlemage's Cry, the Crybot's version is now used, with the proper crit.

This even happens when Autoexertion support is linked with other Warcries. Autoexertion makes supported warcries not grant Buffs or Charges, so you would think the Party tab's Warcries would take effect but they don't unless the player unchecks their own version of the warcry.

How to reproduce the issue
  1. Import the pob
  2. Look at the crit chance
  3. Uncheck the player's battlemage's cry, watch the crit chance go up.
PoB for PoE1 build code
https://pobb.in/lMbO7rV_2gei
Screenshots

No response

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Importa el PoB enlazado y compara la probabilidad de crítico con Battlemage's Cry del jugador activado y desactivado; después repite la comparación con warcries vinculados mediante Autoexertion. Usa la Party tab y el ejemplo de Battlemage's Cry como puntos de entrada; se considera terminado cuando el party warcry más fuerte se aplica incluso cuando el jugador tiene activado el mismo warcry.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
game-dev
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.