PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Warcries in the Party tab have no effect if the player is also using the same warcries
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the behaviour in-game?
Strongest warcry in-game takes effect.
What is the behaviour in Path of Building?
Warcries in the party tab have no effect if the same skill is used by the player.
Battlemage's cry for example:
Party tab has the following from a Crybot:
--- Battlemage's Cry 257 0.5|Skill:BattlemagesCry|CritChance|BASE|-|-|type=GlobalEffect/div=5/effectType=Warcry/limit=25/warcryPowerBonus=5 ---
The player is also using Battlemage's Cry. If the player has skill enabled, the Crybot's superior Battlemage's Cry, with all that crit, is not used. If the player unchecks Battlemage's Cry, the Crybot's version is now used, with the proper crit.
This even happens when Autoexertion support is linked with other Warcries. Autoexertion makes supported warcries not grant Buffs or Charges, so you would think the Party tab's Warcries would take effect but they don't unless the player unchecks their own version of the warcry.
How to reproduce the issue
- Import the pob
- Look at the crit chance
- Uncheck the player's battlemage's cry, watch the crit chance go up.
PoB for PoE1 build code
https://pobb.in/lMbO7rV_2gei
Screenshots
No response
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Importiere den verknüpften PoB und vergleiche die kritische Trefferchance mit aktiviertem und deaktiviertem Battlemage's Cry des Spielers. Wiederhole dies anschließend mit über Autoexertion verknüpften warcries. Verwende den Party tab und das Battlemage's Cry-Beispiel als Einstiegspunkte; abgeschlossen ist die Aufgabe, wenn der stärkere party warcry auch dann angewendet wird, wenn der Spieler denselben warcry aktiviert hat.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- game-dev
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100