PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Warcries in the Party tab have no effect if the player is also using the same warcries
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the behaviour in-game?
Strongest warcry in-game takes effect.
What is the behaviour in Path of Building?
Warcries in the party tab have no effect if the same skill is used by the player.
Battlemage's cry for example:
Party tab has the following from a Crybot:
--- Battlemage's Cry 257 0.5|Skill:BattlemagesCry|CritChance|BASE|-|-|type=GlobalEffect/div=5/effectType=Warcry/limit=25/warcryPowerBonus=5 ---
The player is also using Battlemage's Cry. If the player has skill enabled, the Crybot's superior Battlemage's Cry, with all that crit, is not used. If the player unchecks Battlemage's Cry, the Crybot's version is now used, with the proper crit.
This even happens when Autoexertion support is linked with other Warcries. Autoexertion makes supported warcries not grant Buffs or Charges, so you would think the Party tab's Warcries would take effect but they don't unless the player unchecks their own version of the warcry.
How to reproduce the issue
- Import the pob
- Look at the crit chance
- Uncheck the player's battlemage's cry, watch the crit chance go up.
PoB for PoE1 build code
https://pobb.in/lMbO7rV_2gei
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Import the linked PoB and compare crit chance with the player's Battlemage's Cry enabled and disabled, then repeat with Autoexertion-linked warcries. Use the Party tab and the Battlemage's Cry example as the entry points; done means the stronger party warcry applies even when the player has the same warcry enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100