PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Lucky damage being applied even when Spirit of Fortune is removed and other spectre issues
Nessuno ha ancora preso questa issue.
- Lingua principale
- Lua
- Stelle
- 5.4k
- Fork
- 2.4k
- Merge medio
- 1g 12h
- PR unite (30g)
- 26
Descrizione
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
Not related to the lucky thing, but in-game, spectre auras are providing different results than POB spectres. Perfect Primal Thunderbird with level 21 raise spectre and empower 4 takes my evasion from 9649 to 19838, which is about a level 22 grace when I play with it in POB. POB does not give me the thunderbird grace aura at all.
What is the value from the calculation in Path of Building?
In POB, perfect spirit of fortune's "Lucky Lightning Hits" buff persists in the calcs tab "Aura and Buff Skills" section when you hover over it to see the list of things affecting your DPS calculation. When I manually add "your damage with hits is lucky" with the spectre disabled, I only get a ~2% damage increase, showing that it is only making my other damage types lucky, and it is not just a visual bug that the lucky lightning is persisting even when the spectre is removed.
How to reproduce the issue
Create a new build
select Arc as the first skill
observe Average hit (should be 696)
Add spectre gem, set to perfect spirit of fortune in Config tab
Remove / Uncheck Spectre gem
observe new average hit is 859
Check calcs tab, see that Spectre is listed in the "Aura and Buff Skills" section
Character build code
Here is the POB for my character to verify things like Grace from Perfect Primal Thunderbird
https://pobb.in/uPESRHVCLDh2
For the spirit of fortune, it is easier to verify with a blank new POB, but can be done in mine as well.
Screenshots
No response
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Riproduci il problema con una nuova build usando Arc, quindi aggiungi e rimuovi Perfect Spirit of Fortune tramite la Spectre gem ed esamina le schede Config e Calcs. Confronta i colpi medi riportati e l’elenco Aura and Buff Skills; il lavoro è completato quando l’effetto dei fulmini fortunati non persiste più dopo la rimozione e l’aura Perfect Primal Thunderbird Grace corrisponde al risultato nel gioco.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- lua
- Ambito
- game-dev
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100