PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Lucky damage being applied even when Spirit of Fortune is removed and other spectre issues

Offen
#8,444 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

bug: calculation spectre
Vorherrschende Sprache
Lua
Sterne
5.4k
Forks
2.4k
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
26

Beschreibung

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

Not related to the lucky thing, but in-game, spectre auras are providing different results than POB spectres. Perfect Primal Thunderbird with level 21 raise spectre and empower 4 takes my evasion from 9649 to 19838, which is about a level 22 grace when I play with it in POB. POB does not give me the thunderbird grace aura at all.

What is the value from the calculation in Path of Building?

In POB, perfect spirit of fortune's "Lucky Lightning Hits" buff persists in the calcs tab "Aura and Buff Skills" section when you hover over it to see the list of things affecting your DPS calculation. When I manually add "your damage with hits is lucky" with the spectre disabled, I only get a ~2% damage increase, showing that it is only making my other damage types lucky, and it is not just a visual bug that the lucky lightning is persisting even when the spectre is removed.

How to reproduce the issue

Create a new build
select Arc as the first skill
observe Average hit (should be 696)
Add spectre gem, set to perfect spirit of fortune in Config tab
Remove / Uncheck Spectre gem
observe new average hit is 859
Check calcs tab, see that Spectre is listed in the "Aura and Buff Skills" section

Character build code
Here is the POB for my character to verify things like Grace from Perfect Primal Thunderbird
https://pobb.in/uPESRHVCLDh2

For the spirit of fortune, it is easier to verify with a blank new POB, but can be done in mine as well.
Screenshots

No response

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Reproduziere das Problem mit einem neuen Build unter Verwendung von Arc, füge dann Perfect Spirit of Fortune über den Spectre gem hinzu und entferne es wieder und überprüfe die Tabs Config und Calcs. Vergleiche die gemeldeten durchschnittlichen Treffer sowie die Liste Aura and Buff Skills; abgeschlossen bedeutet, dass der glückbringende Blitzeffekt nach dem Entfernen nicht mehr bestehen bleibt und die Aura Perfect Primal Thunderbird Grace dem Ergebnis im Spiel entspricht.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
lua
Bereich
game-dev
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.