PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Fix stat differences for granted skills
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
How is Path of Building expected to behave?
When I have a unique item equipped which grants a skill, sorting the uniques by damage for the given slot should list that specific unique at the top (and any other uniques, if there are multiple which grant the same skill), and every other unique should be -100% damage for the given skill (since they do not grant it).
As an example, if I have Abberath's Hooves equipped, it grants the Abberath's Fury skill. If I select this skill on the left and sort the unique boots by average hit, every item other than Abberath's Hooves should be at -100%.
This should apply to every case of granted skills:
- uniques like
Abberath's Hooves - heist bases like
Boom Mace - kalguuran runesmithing enchants like
Trigger Level 5 Lightning Bolt when you deal a Critical Strike
How does Path of Building behave?
Path of Building does not consider the case that equipping another item for the same slot may not grant the selected skill.
How to reproduce the issue
- create a fresh build
- equip
Abberath's Hooves - sort unique boots by average hit
- observe that the top one (currently) is
Mutewind Whisperstepswith +62.9% average hit, which is obviously nonsense
Character build code
No response
Screenshots
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza reproduciendo el problema con Abberath's Hooves, la skill Abberath's Fury y las botas únicas ordenadas por impacto medio. Sigue la ruta de comparación de estadísticas para las skills otorgadas, incluidos Boom Mace y el runesmithing enchant indicado. La tarea estará terminada cuando los objetos que no otorgan la skill seleccionada muestren -100% de daño, mientras que los objetos válidos que la otorgan se ordenen correctamente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- desktop
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100