PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Fix stat differences for granted skills

Open
#8,093 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

When I have a unique item equipped which grants a skill, sorting the uniques by damage for the given slot should list that specific unique at the top (and any other uniques, if there are multiple which grant the same skill), and every other unique should be -100% damage for the given skill (since they do not grant it).

As an example, if I have Abberath's Hooves equipped, it grants the Abberath's Fury skill. If I select this skill on the left and sort the unique boots by average hit, every item other than Abberath's Hooves should be at -100%.

This should apply to every case of granted skills:

  • uniques like Abberath's Hooves
  • heist bases like Boom Mace
  • kalguuran runesmithing enchants like Trigger Level 5 Lightning Bolt when you deal a Critical Strike
How does Path of Building behave?

Path of Building does not consider the case that equipping another item for the same slot may not grant the selected skill.

How to reproduce the issue
  1. create a fresh build
  2. equip Abberath's Hooves
  3. sort unique boots by average hit
  4. observe that the top one (currently) is Mutewind Whispersteps with +62.9% average hit, which is obviously nonsense
Character build code

No response

Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with Abberath's Hooves, the Abberath's Fury skill, and unique boots sorted by average hit. Trace the stat comparison path for granted skills, including Boom Mace and the listed runesmithing enchant. Done means items that do not grant the selected skill show -100% damage while valid granting items are ranked correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.