PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Increased effect affixes on Tinctures are local and multiplicative with Tree/Ascendancy increases

Abierto
#8,090 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug: calculation
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

Tincture quality and explicit mod increases are local, multiplied, and the result is then rounded off, displayed in game when alt-hovering tinctures (see provided screenshot), and that value is used to multiply the effect values on the Tincture.

With the screenshotted Tincture, I gain 37 pen on the character sheet.

PoB calc = (19)(1.2)(1.6) = 36

Non-rounded calc = (19)(1.2)(1.22)(1.38) = 38

Rounded value = (19)(1.42)(1.38) = 37

So, actual calc needs a (quality)(local increases) rounded down value.

Same result/conclusion for the crit implicit, and the other Tincture I looked at.

What is the behaviour in Path of Building?

https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/7938

Unsure if it should be posted/merged here, sorry.

In PoB, the quality is treated as a more multiplier. Increases are summed with those from Warden Ascendancy/Passive nodes. This is previously how flasks worked, but it appears Tincture effect is local to the tincture, and multiplicative with Ascendancy/Tree.

Need to test if the same is true for flasks (duration/effect).

How to reproduce the issue
  1. Activate Tincture in h/o (mana burn not applied)

  2. Observe stats

  3. Do math

Character build code
https://pobb.in/3-ET_hwoQqn3
Screenshots

image

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Compara los valores y cálculos de Tincture dentro del juego descritos aquí con el comportamiento de Path of Building y el issue vinculado #7938. Verifica cómo se combinan la calidad y los aumentos explícitos, incluido el redondeo y la interacción con Warden Ascendancy o los aumentos del árbol pasivo; se considerará completado cuando los efectos de Tincture mostrados y calculados coincidan con los del juego.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
tooling
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
38/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.