PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Increased effect affixes on Tinctures are local and multiplicative with Tree/Ascendancy increases
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the behaviour in-game?
Tincture quality and explicit mod increases are local, multiplied, and the result is then rounded off, displayed in game when alt-hovering tinctures (see provided screenshot), and that value is used to multiply the effect values on the Tincture.
With the screenshotted Tincture, I gain 37 pen on the character sheet.
PoB calc = (19)(1.2)(1.6) = 36
Non-rounded calc = (19)(1.2)(1.22)(1.38) = 38
Rounded value = (19)(1.42)(1.38) = 37
So, actual calc needs a (quality)(local increases) rounded down value.
Same result/conclusion for the crit implicit, and the other Tincture I looked at.
What is the behaviour in Path of Building?
https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/7938
Unsure if it should be posted/merged here, sorry.
In PoB, the quality is treated as a more multiplier. Increases are summed with those from Warden Ascendancy/Passive nodes. This is previously how flasks worked, but it appears Tincture effect is local to the tincture, and multiplicative with Ascendancy/Tree.
Need to test if the same is true for flasks (duration/effect).
How to reproduce the issue
-
Activate Tincture in h/o (mana burn not applied)
-
Observe stats
-
Do math
Character build code
https://pobb.in/3-ET_hwoQqn3
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the in-game Tincture values and calculations described here with Path of Building's behavior and the linked issue #7938. Verify how quality and explicit increases are combined, including rounding and interaction with Warden Ascendancy or passive-tree increases; done means the displayed and calculated Tincture effects match the game.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100