PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Tinctures calculate incorrectly: the game passes values with applied mods + "increased effect" mod calculation is wrong (2 separate issues)

Đang mở
#8,039 2 bình luận 1 reaction 0 người được giao Xem trên GitHub

Chưa có ai nhận issue này.

bug: calculation
Ngôn ngữ chính
Lua
Star
5.4k
Fork
2.4k
Merge trung bình
1 ngày 12 giờ
Pull request đã merge (30 ngày)
26

Mô tả

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

From activating tincture in game I get 89% -> 153% increased attack speed, which is +64% increased attack speed from tincture.

What is the value from the calculation in Path of Building?

From activating tincture in PoB I get 89% -> 182% increased attack speed, which is +93% increased attack speed from tincture.

The issue seems to come from the way tinctures are parsed from the game into PoB, and on top of that there is an issue with quality and mods. Let me describe correct calculation in most complicated situation and what goes wrong.

In the game this tincture has "24% increased attack speed" mod. On top of that, tincture has 20% quality, and 35% increased effect mod. Finally, character itself has 71% "increased tincture efect". The way game calculates all of that (I confirmed with changing tinctures and using my own python calc function): 24% mod is multiplied by quality (1.2) AND then multiplied by "increased effect" on tincture, resulting in 241.21.35 = 38% increased attack speed. This value is written on tincture when you don't inspect it with alt. I'm not sure about flooring if it happens on each step or not. Next, 38% increased attack speed is further multiplied by 71% tincture effect, resulting in 38*1.71 = 64% increased attack speed(flooring happens here too, it's 64.98 actually) which is exactly the same as I see in the game.

So, the final formula is: mod_value * quality_multi * increased_effect_on_tincture * increased_effect_character. In this case it's 24 * 1.2 * 1.35 * 1.71 which indeed results in 64% like in game(well, 66 if you don't floor at steps, but if you do you get exactly 64% AS)

Now, problem: in PoB after parsing your character you get tincture with 38% as, it's in flask slot 3 in PoB I attach. 38 is the value we get after applying quality and increased effect, and then pob applies these modifiers again, resulting in wrong calculation.

Unfortunately, this is not the only issue, "x% increased effect mod" on tincture applies incorrectly in PoB too. PoB simply adds that value to increased_effect_character. To demonstrate this, you can look at tincture 4 in attached PoB, (test tincture). It only has 35% increased effect and 24% AS (as if we parsed it correctly, I deleteq quality for simplicity). By activating this tincture we get +49% as, which is 24 * (1 + (71+35)/100) = 24*2.06 = 49%, instead of 24 * 1.71 * 1.35.

I can't provide suggestions with fixes since I don't know Lua, but hopefully this is enough information to reproduce, locate and fix the issue.

So far, the easiest solution (how I add tinctures so they work as in game) is to simply delete increased effect and quality from tincture you get from the game, this way you get the correct 38% mod value and then PoB correctly applies 71% modifier from tree. Also, I can confirm that quality correctly (multiplicatively) works after latest fix, but since parsed from the game mod includes quality bonus it's not helping.

How to reproduce the issue

No response

Character build code
eNrtPdty2ziyz6OvYLlqz4tlm7gSzEl2y_c4iRNHdm774gJJ0GJCkQpJ2fFs7b-fBkhJpCzSsi3P2Z3d3RqPSKC7ge5G3wBwXv7t1yi2rlWWR2nyagNt2xuWSvw0iJKrVxufLo62xMbf_tp7eSaL4YdwbxLFuuWvvd9emt9WrK5V_GrDRRtWIbMrVXyeoiKXgGosk2Ko0uRUfk-z4zR4tfE-TdSG5ckkiIrpkx_LPH8vR-rVxkAmVyrbsGTuqyTYnzd8kVmgEug7lJn0C5W905R3J0V6mgbQHso4B1QjGSXnqf9DFcdZOhm_2qAb1nWkbspOJ6dnHwYXtWFFSX1YMK3fXp7F8lZl54UsrBz-vNrYBe7IK3UgR_AXsMl4AqgQETbb5rbt2ATB9Hc6gfcmWV48DsP5WKlgBkS2mYNb-55l6jAMlV9E12o_i4r9oUz8OUVmbyNKWBv04yBOJ3ERjeNIS62Cwtu8DeL1HRLItts6X6SFjA_Ozmd9qUsQ3XYFxw4STjdYWszAWgl8iYrhXgz8fTiRk6skKlQDjgixTRHlHGHXpl007wIzAlqwTW3bJQTxLtizNMrT5PFcecSQ9ydxDKu-MV6K7W1CEUeMCorbIAcqV9m1LKLmiFsFsp-OvChpyoO5CJNth2KgxGnrIE9lIvfTvKitr66uZyoDC1M0IOx7AM6Vn4JRqoNQvk2Jswql5fCtJN9FoWr0JF09HzSbCmDJaJC97SC-CqUHzubwfNV-D0b8uAENwBKv1vM8ncQr9iyymvKR9jXxs9ETtZrzA_VrLn6bdyCs90Ss1V6fJPXlwToQNnvS9hFep3px388cY34OX5_V5u0yQbeFazNktw_5bHibR76MT-WvaDQZgf-4kD_UnCAVDmrX16thkYDlagNGAoxfG_RRlKlWQBcJ1G7E4uBRFMEzpnkbJCGsw_ZFyWsIqXZ9fwLR0e0cqMN569U8ZyOEIR0RiP9C9z5J_Jqp6DQTn5LMmP566OJ2W5YBLF8dLXmxWhlmTqYyAzNIV2y7NnIxmDMHdTNhoK5UUlG_rWn9Nu6CeqeUPzwGxg9kMR8wp2QbOcLu9sXaLcxAHME6Oa871znf6aWW8Z2uBrDIQboNoQhGwERkCyy6kLRw0N1GXVDLOYgpSM4ViDLEweG3Gv5EZVe358NIxbWpilW6Twe6L8crQBoZ1MFXkkWT3jLurAS6nEXt8SwkSav5voeO6VrmdTMPUR8m3RwrIRomoyMiUxCFA0igFrIDTttznfS7znTiB8LtZqN0UnO_FKPOiZT9VxL61FeVid5ABRO_4Rzddv5Os7a9GJLXhbm0x7wzMBhpHC-DbTUtu0Uh_R8HaXC1yDq7gx1x_CCI5vjOJ-MxGButFgsIXLbN3C4_DHlEVAvBHH5_5w-g2fUV7na560X87P7Oi_gpvjcMWZnKAsQiKd4ZQCxQ2SKrdF8kcb9IT8F0jMBfmPrEaTq3O2ibtssSMsmVEkHTsZmsti-79AYGP9Tlp_xhvSHWuj-_OspU8vvtyvgb3VcicJgEELXBeliZxiLEMjIX0QiMap4fyEJaQRWnf5ZZJJMCg5Q2rFzJzB--A-kfyTj2wBy82qi_1U8LgEgDavwvd0z9T_86GY3TrLBimRcQf6aTpHgt8-GrjQCxQFAX6yIDF8yzhW-HxMeEBT7hWDDkciF9smFAB0rGI5DOfvm4Py3zlbg8FGDq-ygUNmWOj30ROLZn-8TzPTdEro9VwAMHgir1S4_mTGbF7bQoaMZr3sB08iJKTD0CTGAcb1jnw_RmN7jWzLxI0zifVRLleKySoIHjIlPKklOD5mteGFbrB2sEowZfWq4PQPMPhwrR5xgz_M_-P6hLXNSHfxiFJwRJj93H2GZct1GCeJ8IatogZEdOHzkuLeEEtvuUwTt4YhyY1sfcdfUTdnGfOtz0wxxR0XcdxjQK5qA-BE-OeYBIHWBcoUE4Y1j0mWM71BDGNu_DXzNERjhifSw4EfpJEBsDEqdCglynTyAgZP9sFGdPAqNKSQqcNVmvw_oEI5gB45zyPqI265eTAFp2nxHwt33MHN0PAbp-SYjZhMDABITNfa0cTp8TzGAWZsCUCgDSoSiMCHMNijEGNBhQQhc9UoCEN44DTGccu5qDtugTmCkDXMiluguFvxC6AHbkcNRHmAIQRYJzGAFlbp8w0EsYsGsD14EQc02by4FRiAuqkWsZcAbDgb8waGwL2wFhgvygIwi1X4q35Bl2OcfwRjDRF7aN-ow6oAlA0gFuCG46agkhBiIE-qAH8F6PsdQEV8uolA2I2NaNtpY7hX7U5ViPlnHgEahFX6sEQhjQcRsJmIKwXT0p4CqoEODnDjxTGwEeCvxwQLWwRgf8B65S7ggYCFAHJSsZr1UTA7dh9C5MFngCz4whIItgVH3IDSjQQVhPhGJAi5DWURe0GfQdsqC-WQggTQYUhOYGKAnQJ7qk1y8Vl-h1Yv6C-KkLo4DeNjCFgpRAXWEqRLgusIC4MFAGSTTuuxRmXC0sGyZmxkLgtzDC5hS47ACXgXUOAYaAcEBYLiP9UvFBhbieDMAC9zRLQHCaiSAVoQ2hLifJ7Ha3qe5JBGajAFNQ2-rArNrF0B2wsQq_vfw0eGd-_DYsinH-Ymfn5uZmeyyLYRqqXxC3bvvpaGcMQGBPtvIfURxvabQ7u_C_vauTPXXx8TL8-jUYXH12b8Y3Jwfv94u_v3X5p60PW7_evvueUHzp_jq73No73vs0vHb2vyb428_fL8n1BfVObj5ffvpqq70E4-tP3y7Z2a-PF3sipT9P98W7fDd4PcaT718-Bgf-r0vOj7-NBwP0w2Vo8FYmSeC77P2PobuHroITZ_JJqgshLtOUDq_s725xdP0h-PjlZxaLm-DrXrq3X-yef8zYVv5psnX6XgiXH6db_s93F0f5m7fXnAb4TL1J0re2_2lyE_Hhyc03rqKP--Nv6fnJ-29v90P_hntvhmg3vJ183Ru_3f3x_Wj05gTvff-KT9Li--c976vaejO8eD-6vAijC_fmg0vQ7dhTb-k3dRifi5OveX70-u_ZW_Zla_Q6G78evg2_XN7u7u3_2vPf-pcfw-_XhXN7eTkcB8Hvrz9Hw7cyPfmuAvvdT_LjcjCUxwdfLpX9ZYsfXx3-uPySvxfsG84Gv__-bg_tvhkWozdvvt_efNjKydvbiRHwzlTCL8stp3ynfNLBVBaBRSw98Y72D8Znageif7xPC5XrNv1y-vDyXKtAbuXgv47VKN-7hejnSGeBC3XxygPp3ueqKF15HebVRpFNlPbdoZzE-v3HiYwj7RDt-tt35d5dkmajWX0NUIFD1JF6ifHidqwN--67d2XLblxUyDS5qXcsvWA1ICsKpp6xeml25Xbno96XsZ-bcUeJH08CdZJUgWG1umLp6ZHprUhdDgqmM8rjFOZ7HEPomW8sYp0R_e0ljK0Chb6ejPEUbzljDGy4UiO9Vk9VIQOIkHZOCpjPjp7UjsEGv44hAjE5igl9dO_qjVmrteefNfZWv3XrQcnpjcZQ0HQuC1MzgVM1zESOqgCjJLCz2rRQ96xmMt2HSOVDUiapsxrjbI5VP93py1A1u80m3tXp-bihyVk3QM8qCVolxZ21Sv21ymQcfAhPFmTfeD9jROPt8828JGOloXWyNn2o5nuaxoVKzodKR8O1-Tbez-bbePt88y3JWCWdyqqWI77frBhUjzIsX5Qcp4mFl5gWDb1WNfsyjDK9qboXy6BM-WacX2yaMX-x4fn4P6VkVaRW1Ti2ogn6kOSxnFwNi2Wm5zTVdQXjixbszbxlNnX8DLpXEVn3pI9MhlgW3pbNu96e3538QvMzcqCkZE1J_eHrzzq_0aWoJyzClWVykUUJMG6ZOGZNi4KYNTyjCKY0Hsh7_EjO76XBrTWtjN_hO76P64ZDusIyH8bDrOFnKeNZ0fO8yKIfTee7tH0ml6WtdeM4G59xiuuVlCZuzahbFfkO21EiW5E_M0U1x6zyu5yZWsZ68x2zWW98mtOoimMtlrNGZ1UGrLxS32sWe9odLZt_vXVx-vW2Jy7ZzunX6KzqOsSKkx-oYpJp_ZrveuXL2LC83yJDlvd6vmhiRs-qE9z5ryl_Hje6l6ZF_jT3uZLRPsuUH023hWcsr72dcbv27vm0bE5kTQnhTLP24jQNTuVV5C9Trt0sS6_K7cxF9ao1Pd-850T-jTRsxbjgCAzFcDcJzgtzULzG_IWWGecX3j8f2w0hSyaBVZL6w5j_WsUjVfwB6_sohskeyHy4wPjZ2xrTZ--ek-Hw0zJU_tV5_aAQr-K2MTKD6oLAjNu1tzNu1949YzBnqFiGzL-VarMHVfkuhpMkKK8u3Kn0zdruVPtmLX9ExW9KbN3x0m4QqECfZ5nfS7nj2ha73HFwix2eMY4ytCxNrCr__uGFCfQkzXRXDKqmETIQ_ZGofCHOT6KxyvJTmf2oS6P-diYCxNctgpLO_wAz8v_NLUNu3bGWRvoheR0trwzOG-_kuPOmZyxLAxHrQ2JpMs-hfHk6yXylUwalXpgd8DsDe2LMNWPbbhTrMueektmiIXs8f-4ypfp5rgqzAVpuceqfhi2mx0kynhQGyauNUZT7l94kDPV9PRhtkZl7iIdHR4f7FyefD6uzTXUQM6PLZDLy9DzKf-trf2XPc2WOYFr5xMvLn682PkfqxgzkADQxinM9mziW47zmE_UeZjXyGOA6sJleoBBTC7gc17xDO6bDXyorYL5fZOZnkWod16z9nkGVBPUJX30WrA2bvijXjqisAeuNt_IEcgunzB3Fdiz6nmDrdHRjB-zJaCzjVspV6z2cKPQuNmhoFEa-PkbXLXK951326uDL7KZFq7yrM67tOMzNwzYEZWM7cHkNsA26au3gqrmB2MrVsrUd_ED5snXuZWM78OxQe1ra6-VYZr06ML1Py61nWDSVPWuV7GGsZl3aEX4ohiqrjvC1YToFGzXt0rlwssibFO3LuNajg1fmkk4Lh3RbO2h5yaRlDrqtwxI1Lle0MLTepx1VeSWh1ZB1gZYnk1v5V51z7hBBtZ_Rwv6ytYMJ0zsPLfOvmjsWibG_u9dpFJQ1oJblstCty2CkeufwqWjMEf6no1k80_90jJDh5z9a5V21toN_gqgZYpglWMqYZSUkelE9DYNeW0_DcAFxYjHJ1ONZMVgMRebUB91ByOwM-lLgaWuX6aiOpj8aQ3mA_tHg5nz_o6GNA4BMQcEMOj3ArE_HAikmyQEwo-hYHCuiMsNabknms3sQrtIXLp3pgzE2jn91GYHaea12RODMX3eEi6thml1Tea1krD-akMZPQ3jnWu5TkOmLd5OxTIIpug_LgvS5HFbkXlrkgNNczDjQ9_ueysNEjW6XIGof18udaVpn7kroRKu6T3JeZDrB_T1NR99Mkql_VQdQSXXoFELugwjklhl9m9LRHb9O78K8NDWD6gSs_j07ANuOYJKr8ssAZRXHQEyTZoOvfmB1ICEbuX1hDXYHh72DSf7Deq9TxN7r2yCTuQ-5hnUsIfWNVZH3yhDihYUorn7vyXz6hYQoVi8se9txbNGrYoWyZ_XQ0vVTEv2cKOvk4IUVeCIIlE99ThALHG5ziqS0sR_Ynu0KHNg8dEOusMsD4SHmEo_jMCDYhdSBIdEzkzNMfmE5vFcd3H1hYbtXHVh-YR1vDbbgn57pNlA_X1jM7UFWFUd-pNtx78sQxmdJqxqZ0Qoryq0osW5hytaZvkAMDO9bm-Iv-vs88NsqUmsaGlgmUKhqdr3dIMgtodsRsfRtvelZTnhTHTjqbSLHIChAkFfFsLfpmudRuQQt7aJ7m5j9Rb80KMpQUBPubRLbvJ-fyKg1_sPPZFio4J9mFFj3I7zW9e5QdDXjVFfbE3if6b-gittso9KZqt7R2gPf24Pc24Pe24Pd24Pf22N6V91U5ZpLAy9ZGsdpDK0DFU5ApvsQx0eJjK1BOtH7YSYnmK0OzO3W1YGpQ-arQ_dsXR2ma211hIFtE8-RXhgKxkMBym8jIkLXxq5PAoxISOClJwPOBEICex7yGZLcdj2PINlcHW7b6oD_19YG5_W1YfccUDYI1jIFww2s_Znum0i9h0i9tVQpy9RKet_SiVWA3YTV9hcr0zeFocfhryKTUyUMs3Rk6dqIvlFcHSuCpeHylZfCTNs3MeEGrBSDBRGaOaqUTmJLZ9h6CV9rTqfJn0zhl6kzWaLOe5kceWDltLHvHURyBO7CGgCT6honQu5LRJlnM4W4UtQJQZMoFohTz3dBt4TnB8RRMrRdGYAOEgU6Gdi-Yr7vsYbGCdZqclEP87rilJXYRV2otK23SUXTWFJXP58kBVjd6EqVRlHc1Rpaao3ZUFmmNcitD-IwNrd95dSQWzdRMZzptCnr_gfoDl2iO19SiAluM9W7SMfy9ztaw6gEBXE8wkIU-I4iyAlQwG0G7lyEyLY5YyQUXMgAgWtn2BdS4cBHWs-kveDFcU1rqN3Umk3stLu-TQfptsq8WgOpK829TU7vKgaiBo0Epz2X-hwVGCFCl6rOJl7F9yLnP1uvHueEWVPzTnePT_Z7etclAreVF9M9uY-TCMKWKIZ8wjJVAr2DDAmfdQ6ZwVjv3jV8qI0FxR7DwucqdLF0QQO5H0rPl6FLQuYRrgLX8ZXNiUPBzXrC8aSPQI99W5KmRUM1H1pXU7fpM7FbjxKvtP-R1VjL_Ly84gOxpRVA8gaNC5avR0nNZ5pET8_yfAg-10oryNLFla1rUo9lYuFNsXx6f_Lx02HvVBYTaV1MxpNE9i5klkT5EMZ6Po6g2zQ-Kguo1dMLi9BevaS6JAAixK0Lz_cVxDrMkZJCRCOpRBAP8YBKR1FIAxzp-0yQ0BfwVyAHYqWQggNjkDdIXyjeEB4nc-HV4p89q54ZYNI0OA0H0YjyN01sbSCNaAw-6HQaJdr66D3fHmMNO1DnBsA37JIuqfVwI9ZSM7m_T5Ot_UmWK2t3AjlaGTiZzKS6UJlWiUpJPH80IlhuAAOJA0h0rqNlqPfnd33OMgO0D3GSSjQbD6LrKFHGg8wNzzms30V36DIRgo66NnGly7BkRIpAcYx8UF4kAgjpIXpySIB8jplPHPi3KxjYIia5azfdIWuE7bU43W7aHI7rIp9-9wimX6jeMTChyK2T0Wiiz-mW4TvE6Np-hGkGyWp5Exwy3lAXEwKQvc6Ip52WIdhPs2wy1hpfHqPqwiONAsKjd7sItya1WiZOsUycZ2kB9gbSuFwVwzRLrGklWgvzEHjXLE-4LieB6zlgUQhTEgwODbzA9jxwFQFVzCWur6QthQocj_OQC9_2IKTBoeT-ipJkeCE0Jo2kanlQXAYR5qNSVln1yXuE3V31PdHQC21mrL0JzNsoBhGNxhq2Zi73r7P2lwnabVm32rPoaQaQ_UX5COJBvyHukySc5AuL1yaYcwhdibIxYS4Sti09yLN9aVNXZ-KuFxI7EKHDbSWQTxT1mO37iOsw11vIuRsuZy5xspAMIcTvDxhXkDUTHbJuSLdCfKYSZViUWzqTXx4L_2sLH9lLEpbTNPMiXabJ0knQO8pSCDEgXHynpN4ZqBUrbdxVj2GI1XXDRUgFiFDbA5njwOPYZtTxlA8psqc_5hJ6GAmkvMAD6-Dob6RQRoKQUJ9hypt5DiNd1crjrb16fIma9UqQ_UIhZiE2QX-pxxaLVRMk5sHlbIseOvycQEdzfgCiE6IxHKhfhdJ87bGmhi7kWAiRJUkWXyFVAlC8JGv7T8uHOnqIDt1fVtKfXTyGmDRW9bK-udMwL1pS0V7SdwWtFS2p6Cjp6671EpLtE99T4BE9YTs60ReEYQbmMVBCYCE835GKCwzhuvQkBEGQaiHhYQXRveRe04DS9qLlwOoq6ZfHg3ITv0ZJCA1FmWtVlg-WUGjuAPcOsnScW3vAwUJvfWSmwFvGLaMUIr6rvvlcl1ZgPI1vepuENEpSDm3UQcsipL45UfENVgO-W4cwn6hU2v5a-lusZWgJCWxFxuSRNXtefY6u8smoQVLvxBqCpTmYxn-mQLuQis4VRMdsdBazwep7C0nAf9fenbXX0cPtWJ14aeZsPiidTqsZ089L98zVypEESw1rzIdEo5itVM5460qFJcXmK9UlTvtKFeCNGitVuYQLST3FKSQfnAr4VygcN8QKudxTjLNQcR7wQBLXI7aPfVfSAPKb0IGezZXqLF-pe9ax1XRm3GkmLpvMbroaZM_dU1UYnn52dOrgmvFSI1RFrnPfUsRVbU9_G7LulJpZ88JyOwVeTiChOgIjOs4i7ST__BkxWraTcJDJK7AVe9pCDSa5jqrPZT6sq5bjhQENVBi4oFo2x4raVEgbhZh5vucwAmobhhA5CcmkD1rmeciT2OPSsakSzcRJNEptCwUaxJbsIyyqyyax67Z3oRCD8JINJ4Ja9l5x95bCJu6Iev4DFGbZ9sFRCkZNl5V6-5E-7q6s3dEkBgNX0xjOqQyRg6VwPeY7ynWJIDyUDAwS94QSYKtcTGQo_QASZP3RRE-5Dgct04rjLtZpa5GB04wM5jvkMbhKk_t8geU8v_RxOPL0N6nATqC6jzc2ZG6lQBPubEKZPXcTGDDRuee-6dp3VI64d5K3WXxQRcZ6Swt3b4Ri9N-th2cJtdkSxT4DlVCjNIlAhgP5e5r1jtUoSiJrP5Y3jcxRKRwGPvK474cUcw9U2xF2QMKQ-IFnK2KrQEpFXCRD4gSB9DnxfGyjQNFQNAvZoiMorjtap1FXIgtHQ5DRQMTrJ1SmdT4i5qFoeRjmdVRMGxEtlbPZaHC6JsRFgjWQmiZmzrfoILh2vW1hF7jhx5sFjradYdTc9jVV9E26fO_uv4q-priWL6u3HSaB_haz9UYGqrkvt6tNZDpuVlYd36fEFsQNiUIUwgWsz7lAEGArSAUhVtDfbiU4VNJV0nZDWzoYezIIA4bs0GnNEhtlNrqwLccXjrLonbhZpkSd9grHH7bZhpbuQRxFv3RN__-3Zv0sJet_q-r0UoEt3WW4UHnxp5TXw7cYMP0zbDGgpXsMFa__nLtJ3UsT_0svTf2N3rZD0c2P98ZpYUUAceZ9GrzT57fLK7fTD_DqppP6UNsA5vfnZyDsPhhTj7V2vds81wIxcZzF5hjsexGouFiExw-AL900mUOIVadpvl-4SJo-gPQM0ROmP_uY4tNxLJ8QX8OE-Bom9CgcyyaEHqJcy7STrIEjeF2zeYi-ld9deRI_liw2_uQR4AdjqFkY_DiaZF0CYGvQBrSG9YHWMA76QFWoiYE8ycjgp65JugYOPtxrrM3IkqfOHz9xET9sALOvyD5FCcvw4ikYlq9s9mQMfF1iResyMg9XzXoQ5jyODfTJwmTr0aqHzL6sqtcmTx9rDMkaTAp54rKkT4RH6xHAo53lHI6vpra1CSOxGkhNO5C76ujmMPgxfGVPtddrEgxdl4FZW3RNHms7HwA3MOdQ5gDkcdYJr0cGa_MW60j76OPmVFtCq3G_pr_0cdxfU8TBnuyknu7m-EOtQY3d6FHm4y7Fsvgz_QCbuT9vvr-WJmF0Vd2kLx-qu_QGaPamURA6i6WvhmkcqKwahNJ7XOXnv2bfXnPs2WRbAHSdbfqfgJ1CsXYYc7PnvPrvXkz7o3toTPV31h93EPBT842Ch1HQs5h-9W0KQzqmPtKfxx_Hkcq-RPqkrQoMxX39Kb1zFYc1yuwe0s3_0nCN9ffAVf9l4jSOTcGwLrN7IGdfQ5pC8A5aeXQVxR9C8ykWmKP5nswCV1_uzFSs_HCEefpr7-XOmSyGH0LzFQswKH_t_R_ceroT
Screenshots

No response

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Hướng nghiên cứu

Bắt đầu bằng cách tải mã build nhân vật được cung cấp và so sánh các tincture đã kích hoạt ở ô 3 và 4 với các giá trị trong game. Truy vết quá trình phân tích tincture và tính toán hiệu ứng tăng được mô tả trong báo cáo, bao gồm chất lượng và hiệu ứng riêng của tincture, đồng thời xác minh rằng cả hai ví dụ đều tạo ra mức tăng tốc độ đánh được báo cáo là 64% và 49%.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Đánh giá

Công nghệ
lua
Lĩnh vực
backend
Loại issue
Lỗi
Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức độ hoạt động
Đình trệ
Độ rõ ràng
Khá rõ ràng
Mức phù hợp với người mới
35/100

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.