PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Instant leech calculated incorrectly for simultaneous attacks
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
In game, when utilizing Bloodseeker and another claw, leech from hits with doublestrike is instantaneous and capped at 10% of life, as simultaneous attacks generate a single hit which is then used to generate a single leech stack.
What is the value from the calculation in Path of Building?
Path of Building calculates independent leech stacks for MH and OH for simultaneous dual wielding attacks such as Cleave or Dual Strike. This results in a doubling of calculated effective leech when using instant leech.
Additionally, local weapon effects such as Bloodseeker are miscalculated, splitting the leech into two components for MH and OH.
How to reproduce the issue
- Select "Cleave" or "Double Strike" under skills.
- Add the correct weapon types for the skill to make it usable (axe/sword, or claws)
- Add flat damage, life, and % of attack damage leeched as life to config (for simplicity).
4a. Add "100% of life leech is instant" to config. Observe that instant leech is calculated at 200% instead of 100%.
4b. Add "Life Leech from Hits with this Weapon is instant" to one of the weapons. Observe that the "life leech rate" section now shows 10% life instant leech in addition to non-instant leech, instead of a single 10% life instant leech on hit.
Character build code
eNrtW91T4zgSf578Fa5U7b1cDfkGhoPdCgRmqCIDlzAze09bwlYS7chWVpKB7Nb979ct2YmTiYwdu_bpoAocq3-t_pBa3W3n_JfXkHvPVComootm56jd9Gjki4BF84vml8eb96fNX35unD8QvbifXcaM48jPjXfn5trj9JlywDU9TeSc6q8pp95vwGlJIr2gIhqT34X8KIKL5mcR0ab3RKKA6fSTz4lSn0lIL5pTH8BNjyifRsHV5n5CuCCS-JrKO5x1GGsxFgGMahnDaEhYNBX-d6o_ShEvjVDPjL5Ymtvxw_3kMSMSi7IigUbvzh84WVE51UR7Cv5cNIdgGDKnIxLCX-BGeAys-oN2u9nKRVzGUukdWOfUDZsuKQ02lEedft9F-iDp9WxGfc2e6ZVk-mpBIn8zy8A5R2niccw1W3JGZUaygQvx6QfuHbe-j0ITPnqYbiTp9E_ziYVeEzvZfmN6ccnBlEVZ384jpmmWutvv5bL_EXEyODnNQzwIpkRUVtmiMl3FnMOOzJI7aSdUUflMNNsWx81bhE8s2rZmnrZDScn9zK7OCQlYrMZUS6o2iriQYxKRK6E2Lj7Oo3ygEuKD3gK03wBMqS8gpGzNcXR63C8wz360c8I7NqPFKUvpkgDKSnOYHtfTonSlGR8m0ASiaTHKqYh5QUq9CW7dnI3zR5aw03YuzxF9LcYvS3ji3Be3kS7AbkSfhTYH51vqmuhy_elhE4oGvQ9Hnd6g8wFizIlTrYfFSjGf8DF5ZWEcQqx_JN9plDlIjnNW4HyhI4hRLnCvc9xzgW-YpIfgrgQPDsItiFCHAMeQfXyCtGbo-zEkKauN2-DYHzgNez-bHYDCTV3I9pBX-GdIfRv5xWLFl0iaUyKTjuQ7d0YnsIcx7XnitDBmM00SC4pkDXayOY2SGVfFVLqj1F98BP9MiM5kJ53BydFJ9zTvACiQKBkLI20hCyPhXgsXA5SwFQIdtjr6kAfaby13MI-onK-mC0Z5UI46FeyKLAvEaTRzFl3I3NvTlVo4WWhJk3wjMih2mhWjKiv5M1HZw6BznG9US15s-VJIrgEQ0J1Uv-2uVsTvWKvwcrChDEUsCy4LS1xIgfQcs6XZhAaxX-zgvORQWe5I380Ti_N9ELfCWhP_-0gE88I2MpOUQqzrRgOdxsslBBZ0flEGeBpDEcEymdX74wLU97ByC21zPLaLT7ChLjzBOhkpPssOpLgumEqUUGZDXniKtUPHEBtCOBlMH2EsMq0Ep3OgbixUBBrC7XrUvb3EC0i-wE6QKkcNKdcmzXKKImn056ow_y3yQhNcRwGkYbAVCs-xi9g3zSMLIW4qNSKaeEGSq38lkpFId02bSlEi_cUduP6GcP4EkeCimb1rPpnW1g3jmsoR3MNJUbBdjp3U6ect06LDq9twKaT26Cv-eyBSry6aM8IVtYTmDvBRmkWmOwDxiPOmN12Il2HwjDM9CsFVCvLIckmjYIvHo6TUI2l08VEIozx-8EKiQOqVXa4Ktcl0-G4Do0YkQABIhU5Pez3UHetCIlfDbcKIgVwa5so0GruDpIdoOeG0786_TO7MxbuF1kt11mq9vLwcLYleiBl9hePoyBdhawkgEPi9-s44f49sW0P4uZwPzY9h1Eo5ndvmomrZT7hJJQOZrZNbqKixOloCLz4LTRWO4c30w_kUp1LgTak_0lBdrmBj3WCSsdNuSUyJ1FOq7SrJYtKuZ0BnJOZ4_98x4Qw9287evbMN2kjIcF2-ASvwLMZ_y_FxtUTTD-_u7MiQ64QZTpe62bozEchjQeri5Kbpvw43Ul8R7isjN4t8HgdQgiQxZ72MOHlC2bDjjMVDkO3kZjitJ3p3DvIkxB-5eCK8m0KSPjQcyd6chrgQxlSTAHZc61aDEi3UpGXYwdUVp-TZnHdmyyC5vQWa_wo2QLLdm39kzJtcI8nIWrq5JVYnFWtHMV_EkfVlRMJkn9g5PDHzTEaYrC4rarKyEpub1WXXD14aAxuK22gZa8Pyohky5f_2FM9m2PYGVbQ0nfzrm5vrq8fbr9dJTMpCjLq_RXH4hJ1e-39zckypSZE8FT8pe3nR_MroixFkBEZmXKFmnJOlouugYBZIIjkHXA43QwXFdtov389rQ-DmdP1KJcSwOWTgvmTUKdd6_A2h7ISYd2MMd3HD1rSbkc3sriAC2urBYSnzAMDNBfvxTnVwMAcL0Z9w58zJ6BuW0BgiYL2yGfPx-Mt3OQYUS5Vjl3XLw-nvJC118zC9fhcDO-gG2768C52M5ljVPAhwWtWOuuEj6hOn7nbQDV4XpCICM7m4rKlyOH0WkVnksGmGjGMK6fTsNadrEjfDe72gMjnoXZzGEKNSktyNI9lTrN3bOEORYyvTK3NYCMfcUNsCcuiAYzmRaKst4jBolsbNyrYTnIEsD2rLCaf9kuIkxwVJGe4wvx3NMULaiXDonwznbBITf4fPggW2QHVslx2yvIABOVx1Nqbqrs5mtwyvzvEG0uDvTn8no274F80wr9nDxeYvhZjgpqrGAfdWNQ6T3URig53kpxDrym8vOB3N2_hJQXgwB1u2Hgw3VfXBaBO-IaeloEFu_F7T5CxvHUcjMIbOWdoFWRmx9seBjXaleNmTbK-mpTna_Zk8K8rbwpbkDUZwFH_KSfaKcVp3hj5RwvEdBMGrMfzhmVglPYVWJApG2NiuqCj2xeMlMEslu9-XrW9cusv1vJXWUaaFgZVN0niZaom16Z9ChP-5aPY-2Muknu4lNTQkuSMGtpZmjaQTIeGvUEIN7JOWc1OCJiU9XqcVfayofQD-jZKliMztTLGNpNlCewLlql6deZPh5LrxGQRFggbkAN7wlTauJJlpGpx5KEPjQdIZez3z8O2mnA9TqBQLfEjaAWdet91I2iAgxnv4bRiDTOgfZ15_0IBigjOf4Wi7EQlvmfTbvcCYvfG4YMp7Mcr-A_6ofykPCjFtSLBU_U7xJS8wpQd0nXb7J1MMQyk7IdGcehL_4hOsQTOxS1IuOynSJ-umC7Bt1G6eUS-JohySq7_fqh_fw2_Wqp2sVTuNvzSZqzNiqsr_9ts_YXtFUhA38GzzwUsrKw8KTggmlf1QmxdyKHpuP_X2-Ok2wgao9kyJ839nbTsLEzBrGW8mRejhaeK9ML3wNHKysQZpmbXi3-bdHIr-Xv9jo9EdI7d7kFxoD0ru8OHpy-QOA7dtboGZn_F8xyHbH27lAxLzdDaQzluQSwHnmTd8WikFLrGLwxuUmPOScr2L75bAm3zY6x2gpTd9IcvdqfuHMKqgfsKjWwOP_Qod16DQcQ0KHcRjn0KdMotr3-rs1WCRbl3alFlvnygk7rqSPfZstuPKEnRLc6g8Za8u-w9qWAydGrZHpwY5-iVXQl0hplt1R_ZrMGD5M6O2ENurqn-34hYuJ0Cw8mz7ssoatLlFFQ77N_agMofjutzaqSvGlF-a1e3Yr-zLQT2LqozywzDmVNcQCXs1BJRexU3Zr4jv1GP_g0_K0ou2XxpxSBa1gfQOseqgaqyuyS39uoJLbXn1wSVUCdwEyvxSXt8fmrr1-KC2k6KOgq9_mE5ljV_9jK8p2RhUFqT6EXdcNhhUDR4_Tmi7PvYNJ2zDk4BOTQv-G8V3b5Xt05smunnxSUQzNv_hNSY_VlqEYxGozWtPJAhMH7ntaWH_z5ikaWPtn912OxkjaRtO2jYc9p7xnSzbuksAHsemGg08ojzOZsBgkMDNp0Zj85aoTxeCB1QmstGIhqvkS77pC1Yn2S9v7KPPfmE3BQ3yIcl77YJz02bLTvb2XOn7Vymm58YoNmf8fmaeNU41MQ9Md18c-xEVrr9QjN-LpZIGU_NuFL4VN6V8luHxhp7pvl_Td_Pp128ipIDjk3zA9hcFMnZMHxola_C8tfvN-P8B8goutA==
Screenshots
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el problema con Cleave o Double Strike, dual-wield weapons, flat damage, life y leech configurados como se describe. Rastrea los cálculos de instant-leech y weapon-local leech, y verifica después que los ataques simultáneos producen un leech result y que la life-leech rate mostrada coincide con el comportamiento del juego.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- backend
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 28/100