PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Anarchic Spiritblade damage conversion incorrectly applies to spells and attacks with other weapons

Đang mở
#7,627 1 bình luận 0 reaction 0 người được giao Xem trên GitHub

Chưa có ai nhận issue này.

bug: behaviour
Ngôn ngữ chính
Lua
Star
5.4k
Fork
2.4k
Merge trung bình
1 ngày 12 giờ
Pull request đã merge (30 ngày)
26

Mô tả

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?

The Anarchic Spiritblade (Heist Experimented basetype 1H Sword) has the line "100% of Physical Damage from Hits with this Weapon is Converted to a random Element". In game this only applies to attacks performed with this weapon.

What is the behaviour in Path of Building?

In Path of Building the damage conversion from "100% of Physical Damage from Hits with this Weapon is Converted to a random Element" also applies to spells and attacks that are not performed with the weapon (e.g. Spectral Shield Throw).

The same bug also affects other items with the same modifier wording such as:

  • Capricious Spiritblade, which is the lower level version of the Heist basetype
  • Story of the Vaal
  • Fate of the Vaal
How to reproduce the issue
  1. Equip Anarchic Spiritblade or Capricious Spiritblade in PoB
  2. Add any physical spell skill
  3. Check damage composition in the "Calcs" tab
Character build code
eNrVPGlv4kq2n5tfYSHN0726hLjKeyaZEdnTN-mkIentS6uAAtwxNvGShG71f59zyjaYxcYOzEivW0qM6-x1lqpTRQ7__Tp2pGfuB7bnHtVJU65L3O15fdsdHtUf7s_3zPq__1U7vGPh6HZwHNkOjvyr9u5QPEsOf-bOUd0idSlk_pCHn1JSyncgNWFuOOKee8N-eP6F1z-qf_BcXpe6zO3bYfqp57Ag-MDG_Kh-z8cTh_l1iQU97vZP5iNX7lNkB3bowWBvxHzWC7l_jexbUejdeH2AGTAnAHpjZrsdr_fIwwvfiyZHdVqXnm3-EgNd3dzdtu8zstluVjbQ7d3hncOm3O-ELJQC-HFUb4GJ2JBf2iGQYk4EdKhiaFZTNqhR3y9EOo78IDxlY3isgNyZcN6fwWtNk-RB3vn8bDDgvdB-5ie-HZ6MmNubs9L0pkW1POQ3IdxETmhPHJv7c4WaNA_jcoUDkeU84HsvZM7pXWcOq5iyKjcpoYppFGN588nJpf_ZDkfHDpi2Mo-roWuHPIumKLrc1HRAMw1CrSKWq8hEJaosNw1D1YhmkCLkO88OPPfNRnmDyCeR40CcZzFzLdrmAfefWWgvipgLf-KNu7a7NAHljNHyObsdxM7eZn07Cm546PNgrl5TzcO9YS478YK5iyi0CPSO-5CAwgUMeQNCh_c8yFlVUJBHRcxre8DLQ1bSI0GoKs3b9DjrlIVbT5iYGuSpQqw3SNWGLF0OsuNFTknIMJMnFSs_kJ6ykITmxsEpf52BqQWB-ZQFLKB35WbKmlEkYBaSaFa-gM8eJoTNthFJ6uzyLsOfKE2imhaVZVXLLUN3o2lg95hzw17tcTSGGnPPHrmbsXN-ab22h6PQhfyWh0w0U8lDPrd9_ha8E8_pvwlvxLwgH1EhRZFZyhyw0ugdIPSV25shmIUR_-D6IutnVijFBh_wNgQhroe6Di-NM2eTBHOZFUTMbMjdhON0Hip6UyvCuua8N7qAxWObhbxcCp_by7IK7YvAWfvmL7AQco19CxgsYlQwFSKuNxWVm6QIq6KpzlzuD6edkc2dzJqWKGXgU9lO2KQMqrB2Fj9rdd0ox3GdSUopt94ult5ULS1X5M_M75erTFUle2ZBNgsTvdhqMXjWYPmuw2ERDQh9vrS2l_O3Kd4P3KQ41dBa_tiL_BJFFjWIgbMK5NeotILEO7M270e9ciXr2IG95ZL4tMgfHWcdipmrcRiy3uOp1x-WNpJgUgljtmMUqJ1oMoH8gbNflgDWQVj625kF0J5qbIa-BdfNhrJcVDDLM5hDl2YwWwaU57KEUl4XLOLLbDRaArw0i9mE3kByGEMBEA2EGy-TWZpW_vzAhq_U7k0ALu4p8yPeewHhR9gXCja7fRYa1jubEc597v6cLtOXS4FnGRRUoX7kYzSU5rGMkWWT7kxvbBfCbLVNtNwhsqBqEJkQTTM1xcxDXmwTkaaS_bdTpJXOjGJZatOUiaYSophaMd6a3swK5NreTEku65ssFZBXmywV9VsXEivABY2VFdgNjZVV2msaKyV1WNgrWEQpBCxehKxFKV4urqCsXS4SVSdlECqKt3n1lqLe22NY9ATBKQuZ1E92uJ-YbzM3pCBfXQo483uja0jb58xxulDFj-rZt_hpCZEgItI_3BcddXy6Gk88P5T4K_66Y344TVvbAlC8ATpBaLvCOyCFOE5d6oy8l1b_GdPPvec5wawfziYT7vYXaNz7nEssXQD0UAihI36QxiwIwXZxRQEyv8B1dNrQVdPQfjd-aRpV5IZOqUZ_LzTqr_rCCq4HsqHrmSppGKqqNjRDVRq6rBq0oVFNpg0gQI2GaipAlhpUVhoqwVFDN82Gomma3tA0YgEXAggNXVFVo6FZitZQVGIAtEU1taFQS6H4BlnIKCIllmY24IdMGoSoVG6oikF04K0BPESBDMQMAki6pVpAXSVWg4LDN6hqAIBlWkaDypQCEaBIGgoBnYGRCUSoomtWw7B0GUSM-eggkSarFPQCSU3QztIbBPWhsmUaQloCDBRNaRAFtrsNYhJgpBGQtAHJlqCKKsDEJlZ1FEAHpsDaUE1gqlNDblAqwygB1WXgoYICOn5WLQUMZVICRlN0BXAsCwTVdBmEprqp62gXilSE0pZhoUWAhapaMogra0hc1kBfamiIRCwQT1cpCBbPs6oSU4WpokRFkUA1TZYpCK_rBlBQTBMNC6aBZ2qgUqauAkMwDuCCLUEdBXlppoyQoATw0gmoLKP5qGai4CCCCaLpRsPS4IdmUEoxdLBzx_xpa9HLXBv8PQQfzhw3UTU5SUIATbjzu8OH9rV4eDcKw0lwsL__8vLSnLBw5A34K2xFmj1vvD8BJAiEveDRdpw9JLvfgn_Hw4fjr9-i0WX74-fu3ov6s_3tm2n8fGKPt3brWL2yo_svzvPgy_l073zQOx4P_-6cf71h0afet5vrzrT3FNwH9o-X8OKH_fET_-6f0LP3T49Uu3_5qOtfpqfD0-MeezW__rj8dhOY9xQs_BC0Oj8fBtE5V_6e3BjHF9-D4f1wZLxc_vw6Dn9edLpjxj_ZaigHU7M1-ap_vv3wNCR7XeNDcM3uri_s8ejrmKrta2YFr18nH28uIuVTv6vLId_z39vmp8lV94XSu3b43rxrffl4qbavvjmd4CmyTDp4MU4_P3f__ho-aqr79eyj6Xyx9i5arWuLAX9z-vPL8_DoSBh2P7XsYXzSFuzHn3C96tuQAOKcuY8JRWQ3zDj48MELeYBj-DL9cNhB0wdSAAnvgo-D4ykUsXNMyUtlLUlZCN3hYZx0szhH9dCPOGbZAYscfP8xYo6NGZTK2dfX8cGl6_njWRMRaEEKxb1QTPJ-OsFE1rq-jkdaTphQQ35pPo3zZiKRZPfTXJq8FKeRrbnYJ8zpBUJw2-05UZ9fucniO3Frh3VRMjyHxWZZP1Vpic6MzbtDkCYBvnC8LnNoipKczqLmQz7GuLjhIetD_dq_CkGFfdRjX5CDJzzZww3xZ84eXahzWABFjULE1UERLTjUCgIMIBdWu_5jXXrKGjz5gGCnse3rC6KSVNQlZXte5MbT67JxUqJSPv_HJl7wz0AS7BK3i5XYbHa6vdnpRrMLy2CVnjOtNhPXUMNhldgJOXcWZiE7AN74JTMLq0MLEzGTSYizy2lJGEuCs-QNpM7EZ1N4k8zN9v45C8gTWJjcuuiKi745e52AZsySvMli_tccFJlIt66UxgqYxLcf-WY7CGmTlemis2ZGkpetbuA5ES77krsS76P-MGNLUsrD5lQWLDl_veRdawcyEme96r8Q-TPu6F9XbjCxfXSwrBi5lqmYIXaQmBG6ao4gVXPE_cj3Xtx43zJvrS7MZh7IbFazAPn5gux2MvFn6GN0CL6SEGJ1lpJHqKli-RAvEPBRGExAXLmTKBSUj-pYn2NHqEtd2P1w5mY3PEvASOy7G427eIMl_o0evAo5toPe9240GODdIbBK6IuLUWfn52cn91efzhKUDhe9YymIukH8eFT_ZPMXIfUpzKLtBGgNx2GTgM-2YmK1kKjpAF4BNQF1ac_uEa2nNQfIp3T2yn3YOQ4_w67Ut3muXLPxDULFDHG3jRvkPGrYAMonFLe8MX_GO-8cS4m2VT4VzLu56ojcn48Le27m5HJORjdYIsT1Ini3PbB72GEonnJcXcZQBXbp9SKf9aYF85306_NpiI5aHoF4MB857orlYSejBVYVHblcq8aj-einvMdydY8H85FnzRzPFdf21lOZQRVQ-uC5wskhaFq2g7313Jk9c_gMJJ_gbTjiftJeyaN0A5knBSkMHN_uRmF-GGcgCmwl-n85FsKxfNT4FDxHBxwryEQLbb4cg2Zh8knFR6i5iawINT5nybVfcmpTMAXJAWWO-ePRAiOkZ7Q5-ifDBUEi8m_r2bP78cldTrgsgRUlDNjRb09GHEduT2b5fHJ7iucOCx5z5zsZzUd_gEUUrIXWUInXPKWIYFBtRwFjazsK7eWFxBy3XbyEmJ2HrUVOR4sCPzkmezOF-DDvzejirPHN2CJ9wzqYgwaF-XsGU-DeYeSegjHCAtcuSUqItT4PzLWrRCuuZGs1rUwxjs_k-lpRCMcgGwhBKb4sWOyVozQ7Mr_kzMETQM_ZjuDKNb2t9PTCgLn9UzzO2lJRPA2LJkAslex23Wp9PqXLVA_3002XODjCnU1yqtUJfdwR__S88Ve8Yqo2daIRjcqKamjx-6TTqiTdVVjxntpgeF84TMoVAb_gva4mVTWZapapy1Z86H0oNr9J5xef08ZvFPD4Zu9nziaeK16nW2-BlO6F47bfvDHbhtfh9EB6-HD18eGs1gpGPMDGAvi8BPL5Qe3Wnb5KrXHk8LCWHNQdSHc-l5QmVZry_N1J5IMiYS3ev_G-NBuhNaF4mz8dSLpcgx2EY_fAZXHkV89nA4D-3XKg1sKOJ5Cu3AHo06_9CtkwOPjBX6DqcX_6naXLt9-_IGMO-QH5_dcfRN4j-p9S6EnMcaT5Cq-WwMhN7fcf2h6R__wHNjN8zoC0dPY64bChA7NLuOBFjbGjUPuVmAlIZ_GBCV0kkDmQliB2QB0gNhUtP7E7r_1FUCahN75F4eJWS8wnJW5qKihB5T0F6QNG0lVfg4M9Adh6txFTEvh4j0VLpzPpGixDkHic5o3PKCgbIdSNEFo-BCgaw6T37kQjZ-6fsZALPtlutc9qHyC-EKDWcjHI7J7UwY5X2HVYn9dOYuc5kDB0auCVA_v1QMIvLxV86EQD8WE-w5b1-xqcz0m7lXGzMt5O6qvwxFRi-KvUH-JNu9iUmzN4wSyZT3B1uZYcDx1IF3vwPxMUxkJQkMTzJ8mtvO99kYMaEFdYg-Yvkl8p3BygwYQ8v4ks_wM9Kb3fJ8XZTBr43ljCoiG92OEIgt0OpDhzSPB04rmQEzGCMapwCvsAfhYTr1E9Gwex4pLQvKYY2aGl1q8UmzPRLRF9LNpUv3_1oiD0xtmYixtYgdSHeiT9YSp7lroQgLEmCbUIBLYd3v8-9vqp7rPEIvTsseSsJJS6XBK3LvtvjKgZxP80ppbjZZbP1ZTVunx-wxzWGzE7PSe69rxJ7ZLBRsydRVLSfKzF28vkE_irQmrZHecxmD25Tw2mRi9dqAa0qWeLQVwg5NVXhJSrGer6yDneg__ZcqItlZNZAm9QcP-sx4jd08xvUji1oSyneqL9uRlvqUDoWCGWakzWnnNE2lAa6gIyxfKiFSH_RTEUkyWVJFbsUrI2r1FQsidCC2GGWM3YAogEUQ0xsGAaUFrP01GC0rhAIGOsRaUplt7yZK69gIuitqAAigfokNrdYY6KnRFMfyBNvUh6GXFXPAiUHPj_T3FdAGFshDDX5gY8e89bEC4eyjteKNmAcdd9aF_j4jXu9CelAJcOYXz6MjNJHsoxd0Kp1Z0GASZ8Ea0SnePLm_BTlss0tOo06A5oEKnzwibLhPQdKKTvQKEqNI492DstE1AqELjksPNdmVtSRYQ1vvEmM6ybE20Hc0J2QEOtaJBd-eQugqwKDdFKq2T1tR5It_QfpbLIVSbowvGeebCNm6yPmrVeL4au-oAurovioLjBmJJ6jxtgKXmVZVVKhMp2IlvbqYpzxI2FOQJ5qw8rO8irytaqq5XNXSUQ2rhEom_NnJWV2zbGtcrG2L4u0a0pbC-Duq3h1JJpQtwLX0wTyasKaaKwuiiVVOlPpfiMb_eZU9vVeoHsRiO67RxXXsNtnZv03WiubS2IUjXlkW2NTXZQHNRdrdi03cyDvuUKavv10LZruB2ForKr1LAzQm_Z3MxRlAq22JVP7mgq3hwjJQue-CrNYsFLXq0reGsI4DeWFvHjNyXRxZekFvGTVxUK7rpQ2Fl5ozvIdLugQXal0M7S7iqhuG2W3qoVR6viUq3nDuzhyvXXKOCLX-KeXa0Vx7azb0H3-Mhz-txP0LjLx9PkS8bp7Voj-2dI1sFn_xJdiqQVoyz-CYc5GqGWupnZMpayQcDkD0V4jiMak1nVchHHs7-Uh98x5j7vd8RNV7wX3eHOICPzBl3T3JfCq6pmkWKU2dWyFMdUTDMXJbCHtnM7EPMNQorpngmXXgNI3ORwf_kPQv4HyM_3SA==
Screenshots

image
image

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Hướng nghiên cứu

Bắt đầu bằng cách tái hiện vấn đề trong tab Calcs với các vật phẩm Spiritblade được liệt kê, một phép vật lý và một đòn tấn công sử dụng vũ khí khác. Theo dõi cách xử lý chuyển đổi sát thương đối với cách diễn đạt của modifier, sau đó xác minh rằng việc chuyển đổi chỉ áp dụng cho các hit bằng vũ khí liên quan và hoạt động chính xác với cả bốn vật phẩm bị ảnh hưởng.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Đánh giá

Công nghệ
lua
Lĩnh vực
desktop, tooling
Loại issue
Lỗi
Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức độ hoạt động
Đình trệ
Độ rõ ràng
Khá rõ ràng
Mức phù hợp với người mới
38/100

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.