PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Surefooted strikes double damage is not applying to spells.
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
Surefooted striker reads 5% chance to deal Double Damage if you've dealt a Critical Strike with a Two Handed Melee Weapon Recently.
There is no way to determine chance to deal double damage from in game.
What is the value from the calculation in Path of Building?
31%
How to reproduce the issue
- Pick character.
- Allocate surefooted striker from a cluster jewel.
- Add a coc setup with a 2H weapon and a melee skill like cyclone
- Observe spells chance to deal double damage
- Tick 'have you crit recently' in config
- Observe new spells new chance to deal double damage.
- Should be +5% from step 4, but it is the same value as in step 4.
Character build code
https://pobb.in/r7Cr6KMY8X9d
Screenshots
You can find the double damage number
My config
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by loading the linked character build and following the reproduction steps with Surefooted Striker, a two-handed weapon, Cyclone, and the 'have you crit recently' configuration. Compare the spell double-damage chance before and after enabling the condition. Done means the spell calculation includes the expected additional 5% chance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100