PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Allow Trauma stacks to be raised above 10 when Bone Shatter of Complex Trauma is linked to General's Cry

Open
#7,567 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Is your feature request related to a problem?

When Bone Shatter of Complex Trauma is used as the main skill, the configs limit the Trauma stack to 10 due to line
{ "lose_all_trauma_at_X_trauma", 10 },
in "act_str.lua"
However, when Complex Trauma is linked to General's Cry, this limit is not applied in game, allowing players to scale Trauma far higher and the damage scales beyond 10 with it. The mirage warriors do not reset the Trauma stacks.

Describe the solution you'd like

When Complex Trauma is linked to General's Cry, allow Trauma to stack higher than 10.

Describe alternatives you've considered

Currently I have replaced the above mentioned line with
{ "lose_all_trauma_at_X_trauma", 1000 },
Which achieves the same effect, but would allow players not using General's Cry to scale their Complex Trauma higher that 10, misleading them.

Additional context

18 stacks
46 stacks
These images demonstrate how the Trauma continues to increase the Complex Trauma damage with stacks beyond 10 when linked to General's Cry.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the lose_all_trauma_at_X_trauma entry in act_str.lua and trace how General's Cry links to Bone Shatter of Complex Trauma. Confirm that Trauma can exceed 10 only for that link, while the normal Complex Trauma behavior still resets at 10.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.