PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Bodyswap of Sacrifice add support for minion maximum life
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Is your feature request related to a problem?
Bodyswap of Sacrifice currently uses the same "Corpse Life" value in the Configuration tab that normal Bodyswap does.
Describe the solution you'd like
It would be nice if Bodyswap of Sacrifice's Minion Explosion instead used the highest minion life among damageable minions in the build, or, failing that, would create a list of possible minion targets in the "Skill Options" section of the Configuration tab. This way, increases and reductions to minion max life would accurately reflect in the damage calculations without having to constantly update the "Corpse Life" value.
Describe alternatives you've considered
Currently, the damage can be correctly calculated by putting the minion life of the minion you will be targeting into the "Corpse Life" value in the Configuration tab
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Bodyswap of Sacrifice handling in the Configuration tab and trace how the existing "Corpse Life" value reaches damage calculations. Compare the requested highest damageable minion-life behavior with the fallback Skill Options list; done means minion life modifiers are reflected without manually updating "Corpse Life".
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100