PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Incorrect non-damaging ailment calculation with minimum shock
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
With "Shocks from your Hits always increase Damage taken by at least 10%" mod, Level 5 Awakened Unbound Ailments and 7 Affliction Charges, I should get at least 26% shock on everything as long as I'm dealing crits with at least 1 lightning damage.
I haven't tested this in game, but this is the general consensus as to how Shaper of Storms and Shaper of Winter work, as per Mark's response on https://www.reddit.com/r/pathofexile/comments/81b41p/comment/dv3emop/?utm_source=share&utm_medium=web2x&context=3 regarding now removed Beacon of Ruin ascendancy, which was a combination of Shaper of Storms and Shaper of Winter.
What is the value from the calculation in Path of Building?
In Path of Building, the current shock modifier reads 15% with the setup above, even though the shock effect mod reads x2.64, which is correct. I have no clue how Path of Building obtains the 15% value.
The issue is not related to Affliction Charges, because the calculation is still incorrect without Affliction Charges. With Shocks from your Hits always increase Damage taken by at least 10% and Level 5 Awakened Unbound Ailments, the shock seems to be 10% although the shock effect mod reads x1.69.
How to reproduce the issue
Select any skill and support it with normal or awakened Unbound Ailments
Add custom config for "Shocks from your Hits always increase Damage taken by at least 10%" (this mod is supported and works, because changing the number changes dps) or allocate something like Shaper of Storms/Scion Elementalist
Check Non-Damaging Ailments in the calcs tab
Character build code
https://pobb.in/KEHutQQ6uQev
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by loading the linked build and reproducing the result in the calcs tab with Unbound Ailments and the minimum-shock custom config or Shaper of Storms. Trace the non-damaging ailment calculation, compare the shock value with the shock effect multiplier, and confirm that the displayed shock reaches the expected minimum.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100