PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Cyclone of Tumult Skill Stage defaults to stage 1 when calculating Skill Trigger Rate of Active Spell (attached to CoC)

Open
#7,166 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

The information is not available ingame

What is the value from the calculation in Path of Building?

https://i.imgur.com/zlEZiUR.png
https://i.imgur.com/FKlhQ1m.png

When setting the spell triggered via Cast on Critical Strike Support with the use of Cyclone of Tumult (Blazing Salvo in this case), the calculation is done on stage 1 of Cyclone of Tumult instead of the stage set, in this case stage 6.

The calculation in this example is done on aps of 4.05 for stage 1 when it should be on 8.09 of stage 6

How to reproduce the issue

You should be able to reproduce this with any Cast on Crit build using Cyclone of Tumult as proc'ing attack skill, Here is my current build with the issue in question:
https://pobb.in/4l8SCzb4IN-U

Character build code
https://pobb.in/4l8SCzb4IN-U
Screenshots

https://i.imgur.com/zlEZiUR.png
https://i.imgur.com/FKlhQ1m.png

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by loading the linked PoB build and reproducing the Cast on Critical Strike calculation with Cyclone of Tumult set to stage 6. Trace the calculation entry point for the triggered spell's attack rate and verify that the result uses Cyclone's selected stage rather than stage 1; done when the displayed rate matches the stage 6 value.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.