PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Militant Faith search: more than 2 devotion modifiers
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
I would like to find jewels with any two of Totem Damage, Area Damage, Elemental Damage, and Increased Effect of Non-Curse Auras per 10 Devotion.
Describe the solution you'd like
Allow the user to specify a "starter trade settings" link. Use this as the basis for all other trade links. e.g. the user might choose to search for Timeless Jewels with two of the their chosen devotion mods. An example link would be https://www.pathofexile.com/trade/search/Ancestor/7pkrXv2S5.
One challenge with this will be filter complexity. I don't know how hard it is to know when approaching the max filter complexity when PoB is generating a link. This may reduce the number of jewels in each search, and this reduction may not be obvious to the user.
Describe alternatives you've considered
There are several other options for how to implement this.
The least flexible but simplest to use and perhaps also simplest to implement would be to have a multi-select box and let users pick how many of those they want (1 or 2). This has the advantage of requiring less work from the user and making discovery of what can be done simpler. It also limits the complexity of the trade link since it's at worst a count box containing all available devotion mods, though more likely it's just a few.
Another more powerful option would be to let the user specify a weight for each of the modifiers, then search with a specified required total weight. e.g. it might be that one modifier is great on its own, while the others are only good in combination with another one. This is almost as powerful as providing for a starter trade settings link for looking at these modifiers specifically, though obviously it wouldn't allow for doing things like looking for particular corruptions. There's likely to be zero of any given seed with a particular corruption on it, though.
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; start by locating the existing Timeless Jewel trade-link generation and devotion-modifier filter handling. Compare the current limit with the requested two-of-four search behavior; done means generating a usable trade link while making any filter-complexity limitation clear to the user.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100